This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Fix processing of forward references - #304
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 7 commits intoNov 5, 2018
Merged
Conversation
| public void ProcessSet() { | ||
| // Do not use foreach since walker list is dynamically | ||
| // modified and walkers are removed as they are done. | ||
| while (_functionWalkers.Count > 0) { |
Contributor
There was a problem hiding this comment.
var walkers = _functionWalkers.Values.ToArray();
_functionWalkers.Clear();
foreach (var walker in walkers) {
walker.Walk();
}There was a problem hiding this comment.
Actually, the point is in keeping walkers in the array for recursive processing. We don't walk in order. Ex A calls B which calls D which calls C. We take A which then, when it needs return type of B will call ProcessFunction that needs to find B walker and process it. B walkers will cause ProcessFunction on D and then on C.
There was a problem hiding this comment.
So if walker is removed b/c it was called in some chain, we don't want to walk it again so that's why there is no ToArray
added 2 commits
October 26, 2018 23:11
This was referenced Nov 1, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294