This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Prevent document reload with old content - #1591
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 5 commits intoSep 26, 2019
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 5 commits into
Mikhail Arkhipov (MikhailArkhipov) merged 5 commits into
Conversation
Jake Bailey (jakebailey)
approved these changes
Sep 26, 2019
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Separate reset into init/clear/touch * Fix module creation analysis * Fix find references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1543
Sligtly different from #1585.
Found another case of buffer corruption. Happens when module reload comes during analysis.
Repro:
scikit-learnconftest.pydel sys._is_pytest_sessionReloadAll.Separated
ResetintoSetContent,MarkChangedandClear.Added exceptions to make sure Populate only happens once and there is no
UpdateafterClear.MarkChangedadvances version so analysis thinks buffer has changed without actually reloading it.