Remove the check that if base file name starts with ^ is dynamic file name since those files can exist

[Sheetal Nandi (sheetalkamat)]

Fixes #35734

[Nathan Shively-Sanders (sandersn)]

Code looks OK, but do we lose any ability to detect or create dynamic file names since real files can use carat now?

[Sheetal Nandi (sheetalkamat)]

do we lose any ability to detect or create dynamic file names since real files can use carat now?

We already have tests for all the scenarios that use dynamic file names and they work, (I think work to retain projectRootPath for open files has rendered this not needed any more)

[Sheetal Nandi (sheetalkamat)]

TypeScript Bot (@typescript-bot) pack this

[TypeScript Bot (typescript-bot)]

Heya Sheetal Nandi (@sheetalkamat), I've started to run the tarball bundle task on this PR at 4858f4b. You can monitor the build here. It should now contribute to this PR's status checks.

[Sheetal Nandi (sheetalkamat)]

Ben Lichtman (@uniqueiniquity) Jesse Trinity (@jessetrinity) Andrew Casey (@amcasey) can you try our the drop here to see the debugging scenarios are working ok.
I tried creating bunch of dynamic files in VS but I might not have covered all scenarios. (file is created dynamic when debugging in ie and clicking files from solution explorer and script documents list if there is not matching file found on disk.. eg you compile ts with --inlineSources and then delete the ts files)

[Ben Lichtman (uniqueiniquity)]

Sheetal Nandi (@sheetalkamat) sure thing - I actually just built it locally a few moments ago.

[TypeScript Bot (typescript-bot)]

Hey Sheetal Nandi (@sheetalkamat), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/59993/artifacts?artifactName=tgz&fileId=8AAE0DD5296BDA99EDEF45782C5550B9CDEE791E097459DD7D16A0FBB90E9F6802&fileName=/typescript-3.8.0-insiders.20200110.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build.

[Ben Lichtman (uniqueiniquity)]

Sheetal Nandi (@sheetalkamat) Looks good to me. Tried naming normal files with a leading ^, tried using dynamic files, and tried using dynamic files that start with a leading ^. All seems fine.