TSServer crashes 5 times after opening the VS Code Interactive Playground #36681

Activity

1. Eric Amodio (eamodio)

   assigned

   Matt Bierner (mjbvz)

   on Feb 7, 2020
2. microsoft

   deleted a comment from vscodebot on Feb 7, 2020
3. mjbvz commented on Feb 7, 2020

   

   Matt Bierner (mjbvz)

   on Feb 7, 2020

   More actions

   Good find! Moving upstream to TS.
4. Matt Bierner (mjbvz)

   transferred this issue frommicrosoft/vscodeon Feb 7, 2020
5. mjbvz commented on Feb 7, 2020

   

   Matt Bierner (mjbvz)

   on Feb 7, 2020

   More actions

   Ryan Cavanaugh (@RyanCavanaugh) We'll need a fix for this before VS Code can ship 3.8. (that can be a 3.8.x recovery build)

   Sheetal Nandi (@sheetalkamat) Here's the stack and call that triggers the error. I suspect this error may have something to do with us sending along the scheme as part of the file name (we've always done this but I seem to recall TS breaking previously due to this):

   Err 62    [13:21:32.844] Exception on executing command {"seq":2,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"walkThroughSnippet:/usr/share/code/resources/app/out/vs/workbench/contrib/welcome/walkThrough/browser/editor/^vs_code_editor_walkthrough.md#1.js","fileContent":"const express = require('express');\nconst app = express();\n\napp.get('/',  (req, res) => {\n    res.send(`Hello ${req.}`);\n});\n\napp.listen(3000);","scriptKindName":"JS"}]}}:
   
       Debug Failure.
   
       Error: Debug Failure.
           at Object.assertDefined (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:2077:24)
           at ProjectService.updateNonInferredProjectFiles (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:142411:51)
           at ProjectService.addFilesToNonInferredProject (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:142296:22)
           at ProjectService.updateRootAndOptionsOfNonInferredProject (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:142456:22)
           at ProjectService.loadConfiguredProject (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:142382:22)
           at ProjectService.createAndLoadConfiguredProject (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:142319:22)
           at ProjectService.createLoadAndUpdateConfiguredProject (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:142324:36)
           at ProjectService.assignProjectToOpenedScriptInfo (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:143183:44)
           at /home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:143479:107
           at Object.mapDefined (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:562:30)
           at ProjectService.applyChangesInOpenFiles (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:143479:48)
           at Session.handlers.ts.createMapFromTemplate._a.<computed> (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:144343:46)
           at /home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:146086:88
           at IOSession.Session.executeWithRequestId (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:146077:28)
           at IOSession.Session.executeCommand (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:146086:33)
           at IOSession.Session.onMessage (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:146110:35)
           at Interface.<anonymous> (/home/jhony1104/.vscode/extensions/ms-vscode.vscode-typescript-next-3.8.20200206/node_modules/typescript/lib/tsserver.js:147425:27)
   
6. Matt Bierner (mjbvz)

   removed their assignment

   on Feb 7, 2020
7. Matt Bierner (mjbvz)

   changed the title [-]TSServer crashes 5 times after opening the Interactive Playground[/-] [+]TSServer crashes 5 times after opening the VS Code Interactive Playground[/+] on Feb 7, 2020
8. sheetalkamat commented on Feb 8, 2020

   

   Sheetal Nandi (sheetalkamat)

   on Feb 8, 2020

   Member

   More actions

   Matt Bierner (@mjbvz) #36109 removed the check (to fix #35734) that the basefile name starting with ^ is dynamic since disk can have file name that starts with ^. #36240 slightly modified this check for untitled files.

   The walkthrough path in the log does not satisfy this current check of dynamic file.. https://github.com/microsoft/TypeScript/blob/master/src/server/scriptInfo.ts#L274
   I am not sure if we should add if additional check if filename starts with walkThroughSnippet:/ and has baseFileName starting with ^ a good check to add to that.. especially can such path exist on disk (I am guessing yes if windows drive letter is walkThroughSnippet`
9. mjbvz commented on Feb 8, 2020

   

   Matt Bierner (mjbvz)

   on Feb 8, 2020

   More actions

   I think hardcoding a check for walkThroughSnippet:/ would be a fairly safe workaround.

   ---

   Note that vscode can also have untitled file paths that look like: untitled:/Users/matb/projects/san/^newFile.js which I'm not sure #36240 fixes

   Also, longer term, should we perhaps look into having VS Code pass a isDynamic property on the file request instead of modifying the file names to indicate this?
10. Sheetal Nandi (sheetalkamat)

    added a commit that references this issue on Feb 10, 2020

    Handle walkThroughSnippet:/ and untitled:/ as dynamic files

    ...

    This issue will close once commit 7694d10 is merged into the 'main' branch.

    7694d10
11. Sheetal Nandi (sheetalkamat)

    added

    BugA bug in TypeScriptA bug in TypeScript

    Fix AvailableA PR has been opened for this issueA PR has been opened for this issue

    on Feb 10, 2020
12. Sheetal Nandi (sheetalkamat)

    modified the milestones: TypeScript 3.8.2, TypeScript 3.8.1 on Feb 10, 2020
13. Sheetal Nandi (sheetalkamat)

    closed this as completedin #36722on Feb 10, 2020
14. Sheetal Nandi (sheetalkamat)

    added 3 commits that reference this issue on Feb 10, 2020

    Handle walkThroughSnippet:/ and untitled:/ as dynamic files (#36722)

    ...

    This issue will close once commit 70e6f5b is merged into the 'main' branch.

    70e6f5b

    Handle walkThroughSnippet:/ and untitled:/ as dynamic files (#36722)

    ...

    This issue will close once commit 87a3d6f is merged into the 'main' branch.

    87a3d6f

    Handle walkThroughSnippet:/ and untitled:/ as dynamic files (#36722) (…

    ...

    This issue will close once commit 5f623b2 is merged into the 'main' branch.

    5f623b2
15. microsoft

    locked as resolved and limited conversation to collaborators on Oct 21, 2025