Skip to content

🤖 User test baselines have changed #27546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TypeScript Bot (typescript-bot) wants to merge 1 commit into from
Closed

🤖 User test baselines have changed #27546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/baselines/reference/user/bluebird.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,21 @@ node_modules/bluebird/js/release/promise.js(305,10): error TS2339: Property '_fi
node_modules/bluebird/js/release/promise.js(322,10): error TS2339: Property '_fireEvent' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(339,42): error TS2339: Property '_isBound' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(434,26): error TS2339: Property '_propagateFrom' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(436,32): error TS2339: Property '_target' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(471,14): error TS2339: Property '_warn' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(473,10): error TS2339: Property '_attachExtraTrace' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(480,10): error TS2339: Property '_captureStackTrace' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(481,10): error TS2339: Property '_pushContext' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(483,18): error TS2339: Property '_execute' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(489,10): error TS2339: Property '_popContext' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(506,19): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
node_modules/bluebird/js/release/promise.js(550,22): error TS2339: Property 'isFinallyHandler' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(551,22): error TS2339: Property 'cancelPromise' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(558,22): error TS2339: Property '_promiseCancelled' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(572,23): error TS2339: Property '_isResolved' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(574,26): error TS2339: Property '_promiseFulfilled' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(576,26): error TS2339: Property '_promiseRejected' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(601,17): error TS2339: Property '_reject' does not exist on type '{}'.
node_modules/bluebird/js/release/promise.js(630,14): error TS2339: Property '_attachExtraTrace' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(642,14): error TS2339: Property '_dereferenceTrace' does not exist on type 'Promise'.
node_modules/bluebird/js/release/promise.js(659,14): error TS2339: Property '_ensurePossibleRejectionHandled' does not exist on type 'Promise'.
Expand Down
17 changes: 17 additions & 0 deletions tests/baselines/reference/user/chrome-devtools-frontend.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3042,13 +3042,24 @@ node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighth
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(68212,26): error TS2339: Property 'maxH' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(68213,26): error TS2339: Property 'maxV' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(69799,1): error TS2323: Cannot redeclare exported variable 'parse'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(69824,12): error TS2339: Property 'version' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(69831,12): error TS2339: Property 'version' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(69838,12): error TS2339: Property 'loose' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(69841,17): error TS2339: Property 'version' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70069,7): error TS2339: Property 'prerelease' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70069,29): error TS2339: Property 'prerelease' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70215,9): error TS2339: Property 'loose' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70218,11): error TS2339: Property 'value' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70274,34): error TS2339: Property 'loose' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70747,4): error TS2531: Object is possibly 'null'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70747,26): error TS2531: Object is possibly 'null'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70753,6): error TS2531: Object is possibly 'null'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70753,20): error TS2531: Object is possibly 'null'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70754,15): error TS2531: Object is possibly 'null'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70756,10): error TS2531: Object is possibly 'null'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70756,45): error TS2531: Object is possibly 'null'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70766,23): error TS2339: Property 'prerelease' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70766,48): error TS2339: Property 'prerelease' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70848,34): error TS2304: Cannot find name 'fs'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker.js(5,11): error TS2339: Property 'Runtime' does not exist on type 'Window'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker.js(6,8): error TS2339: Property 'importScripts' does not exist on type 'Window'.
Expand Down Expand Up @@ -3332,6 +3343,10 @@ node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(689,28): error
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(690,25): error TS2345: Argument of type '{ from: any; to: any; }' is not assignable to parameter of type 'number'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(691,26): error TS2339: Property 'inclusiveRight' does not exist on type 'never'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(692,25): error TS2345: Argument of type '{ from: any; to: any; }' is not assignable to parameter of type 'number'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(1519,57): error TS2339: Property 'state' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(1519,77): error TS2339: Property 'lookAhead' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(1729,79): error TS2339: Property 'lookAhead' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(1749,68): error TS2339: Property 'lookAhead' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(2428,8): error TS2551: Property 'lineN' does not exist on type 'LineView'. Did you mean 'line'?
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(2429,20): error TS2339: Property 'built' does not exist on type 'LineView'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(2601,32): error TS2339: Property 'logicalXDPI' does not exist on type 'Screen'.
Expand Down Expand Up @@ -3402,11 +3417,13 @@ node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(5935,16): error
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6164,32): error TS2322: Type 'string' is not assignable to type 'any[]'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6378,11): error TS2339: Property 'setHistory' does not exist on type 'Doc'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6391,10): error TS2339: Property 'linked' does not exist on type 'Doc'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6398,56): error TS2339: Property 'doc' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6454,39): error TS2339: Property 'FileReader' does not exist on type 'Window'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6454,60): error TS2339: Property 'File' does not exist on type 'Window'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6464,44): error TS2345: Argument of type 'string | ArrayBuffer' is not assignable to parameter of type 'string'.
Type 'ArrayBuffer' is not assignable to type 'string'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6553,25): error TS2339: Property 'CodeMirror' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(6825,90): error TS2339: Property 'ch' does not exist on type '{}'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(7343,11): error TS2339: Property 'copy' does not exist on type '(...args: any[]) => any'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(7777,11): error TS2339: Property 'wrapper' does not exist on type 'Display'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(7827,32): error TS2339: Property 'lineDiv' does not exist on type 'Display'.
Expand Down
8 changes: 8 additions & 0 deletions tests/baselines/reference/user/lodash.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ node_modules/lodash/_baseUniq.js(30,5): error TS2322: Type '(array?: any[] | und
node_modules/lodash/_baseUniq.js(33,33): error TS2554: Expected 0 arguments, but got 1.
node_modules/lodash/_baseUniq.js(39,5): error TS2322: Type 'SetCache' is not assignable to type 'any[]'.
node_modules/lodash/_baseUniq.js(62,15): error TS2554: Expected 2 arguments, but got 3.
node_modules/lodash/_baseWrapperValue.js(18,21): error TS2339: Property 'value' does not exist on type '{}'.
node_modules/lodash/_cloneArrayBuffer.js(11,16): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
node_modules/lodash/_cloneBuffer.js(4,69): error TS2339: Property 'nodeType' does not exist on type '(buffer: any, isDeep?: boolean | undefined) => any'.
node_modules/lodash/_cloneBuffer.js(7,80): error TS2339: Property 'nodeType' does not exist on type '{ "../../../tests/cases/user/lodash/node_modules/lodash/_cloneBuffer": (buffer: any, isDeep?: boolean | undefined) => any; }'.
Expand Down Expand Up @@ -163,8 +164,11 @@ node_modules/lodash/_overRest.js(27,27): error TS2532: Object is possibly 'undef
node_modules/lodash/_overRest.js(28,22): error TS2532: Object is possibly 'undefined'.
node_modules/lodash/_overRest.js(31,15): error TS2538: Type 'undefined' cannot be used as an index type.
node_modules/lodash/_root.js(4,56): error TS2339: Property 'Object' does not exist on type 'Window'.
node_modules/lodash/_stackSet.js(21,22): error TS2339: Property '__data__' does not exist on type '{}'.
node_modules/lodash/_stackSet.js(24,26): error TS2339: Property 'size' does not exist on type '{}'.
node_modules/lodash/_unicodeWords.js(62,20): error TS8024: JSDoc '@param' tag has name 'The', but there is no parameter with that name.
node_modules/lodash/_updateWrapDetails.js(34,5): error TS1223: 'returns' tag already specified.
node_modules/lodash/_wrapperClone.js(14,20): error TS2339: Property 'clone' does not exist on type '{}'.
node_modules/lodash/ary.js(16,10): error TS1003: Identifier expected.
node_modules/lodash/ary.js(16,10): error TS8024: JSDoc '@param' tag has name '', but there is no parameter with that name.
node_modules/lodash/before.js(34,7): error TS2322: Type 'undefined' is not assignable to type 'Function'.
Expand Down Expand Up @@ -368,6 +372,7 @@ node_modules/lodash/parseInt.js(24,10): error TS8024: JSDoc '@param' tag has nam
node_modules/lodash/partial.js(48,9): error TS2339: Property 'placeholder' does not exist on type 'Function'.
node_modules/lodash/partialRight.js(47,14): error TS2339: Property 'placeholder' does not exist on type 'Function'.
node_modules/lodash/pickBy.js(33,12): error TS2722: Cannot invoke an object which is possibly 'undefined'.
node_modules/lodash/plant.js(42,21): error TS2339: Property '__wrapped__' does not exist on type '{}'.
node_modules/lodash/property.js(29,37): error TS2345: Argument of type 'string | symbol' is not assignable to parameter of type 'string'.
Type 'symbol' is not assignable to type 'string'.
node_modules/lodash/pullAllBy.js(29,34): error TS2554: Expected 0-1 arguments, but got 2.
Expand Down Expand Up @@ -443,7 +448,10 @@ node_modules/lodash/unionWith.js(31,42): error TS2345: Argument of type '(value:
node_modules/lodash/uniqBy.js(28,52): error TS2554: Expected 0-1 arguments, but got 2.
node_modules/lodash/words.js(15,10): error TS1003: Identifier expected.
node_modules/lodash/words.js(15,10): error TS8024: JSDoc '@param' tag has name '', but there is no parameter with that name.
node_modules/lodash/wrapperAt.js(34,17): error TS2339: Property 'slice' does not exist on type '{}'.
node_modules/lodash/wrapperAt.js(40,51): error TS2339: Property 'thru' does not exist on type 'LodashWrapper'.
node_modules/lodash/wrapperReverse.js(33,23): error TS2339: Property 'reverse' does not exist on type '{}'.
node_modules/lodash/wrapperReverse.js(34,13): error TS2339: Property '__actions__' does not exist on type '{}'.
node_modules/lodash/xorBy.js(36,58): error TS2554: Expected 0-1 arguments, but got 2.


Expand Down
2 changes: 2 additions & 0 deletions tests/baselines/reference/user/npm.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ node_modules/npm/lib/config/core.js(160,23): error TS2339: Property 'get' does n
node_modules/npm/lib/config/core.js(165,10): error TS2339: Property 'once' does not exist on type 'Conf'.
node_modules/npm/lib/config/core.js(176,23): error TS2339: Property 'get' does not exist on type 'Conf'.
node_modules/npm/lib/config/core.js(190,5): error TS2323: Cannot redeclare exported variable 'loaded'.
node_modules/npm/lib/config/core.js(208,24): error TS2339: Property 'list' does not exist on type '{}'.
node_modules/npm/lib/config/core.js(208,40): error TS2339: Property 'root' does not exist on type '{}'.
node_modules/npm/lib/config/core.js(213,28): error TS2339: Property 'defaults' does not exist on type 'typeof import("/npm/node_modules/npm/lib/config/defaults")'.
node_modules/npm/lib/config/core.js(237,21): error TS2339: Property 'sources' does not exist on type 'Conf'.
node_modules/npm/lib/config/core.js(245,17): error TS2339: Property 'emit' does not exist on type 'Conf'.
Expand Down
5 changes: 5 additions & 0 deletions tests/baselines/reference/user/uglify-js.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ node_modules/uglify-js/lib/scope.js(462,15): error TS2554: Expected 0 arguments,
node_modules/uglify-js/lib/scope.js(487,15): error TS2554: Expected 0 arguments, but got 1.
node_modules/uglify-js/lib/sourcemap.js(55,25): error TS2304: Cannot find name 'MOZ_SourceMap'.
node_modules/uglify-js/lib/sourcemap.js(61,23): error TS2304: Cannot find name 'MOZ_SourceMap'.
node_modules/uglify-js/lib/utils.js(124,27): error TS2339: Property 'v' does not exist on type '{}'.

@sandersn Nathan Shively-Sanders (sandersn) Oct 4, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27370 breaks narrowing on constructor functions, eg

/** @constructor */
function AtTop(val) { this.val = val }
/** @type {*} */
var x = 1;
if (x instanceof AtTop) {
    x.val
}

I don't think this error is correct, but I don't understand how it arises from the change either.

@sandersn Nathan Shively-Sanders (sandersn) Oct 4, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #27550 to track this.

@sandersn Nathan Shively-Sanders (sandersn) Oct 4, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is up at #27551, so I'll close this PR.

node_modules/uglify-js/lib/utils.js(126,57): error TS2339: Property 'v' does not exist on type '{}'.
node_modules/uglify-js/lib/utils.js(126,83): error TS2339: Property 'v' does not exist on type '{}'.
node_modules/uglify-js/lib/utils.js(133,57): error TS2339: Property 'v' does not exist on type '{}'.
node_modules/uglify-js/lib/utils.js(133,83): error TS2339: Property 'v' does not exist on type '{}'.
node_modules/uglify-js/tools/exit.js(7,32): error TS2339: Property 'bufferSize' does not exist on type 'WriteStream'.
node_modules/uglify-js/tools/exit.js(7,61): error TS2339: Property 'bufferSize' does not exist on type 'WriteStream'.
node_modules/uglify-js/tools/exit.js(10,37): error TS2345: Argument of type 'any[]' is not assignable to parameter of type '[(number | undefined)?]'.
Expand Down