Repository navigation
narrowTypeByInstanceof understands ctor funcs - #27551
Merged
Nathan Shively-Sanders (sandersn) merged 3 commits intoOct 4, 2018
Merged
Conversation
Nathan Shively-Sanders (sandersn)
requested review from
Anders Hejlsberg (ahejlsberg) and
Wesley Wigham (weswigham)
October 4, 2018 16:26
Wesley Wigham (weswigham)
approved these changes
Oct 4, 2018
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
Looks like you have a small lint error to fix. The "effective constructor signatures" change is probably going to require a change to #27403 as well.
Member
Author
|
I'm not sure about #27403 -- constructor functions are still functions, so isTypeDerivedFrom shouldn't need to change for constructor functions. |
Member
|
Fair enough - I guess it'd only matter if the signatures came from somewhere other than the other kind of signatures on the type itself. |
Nathan Shively-Sanders (sandersn)
deleted the
js/fix-ctor-func-narrowing
branch
October 4, 2018 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27550.
I'm going to try writing
getEffectiveConstructSignaturesas an intermediate step to constructor functions having construct signatures instead of call signatures, but that may break a bunch of code if used everywheregetSignaturesOfType(..., SignatureKind.Construct)is called today. For now, this fixes the bug in a targetted way.