Skip to content

ignore last void parameter - #20642

Closed
Wenlu Wang (Kingwl) wants to merge 1 commit into
microsoft:masterfrom
Kingwl:improve-void
Closed

ignore last void parameter#20642
Wenlu Wang (Kingwl) wants to merge 1 commit into
microsoft:masterfrom
Kingwl:improve-void

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented Dec 12, 2017

Copy link
Copy Markdown
Contributor

Close #20570
Fixes #4260

Kingwl
Wenlu Wang (Kingwl) commented Dec 12, 2017
View reviewed changes
Comment thread tests/baselines/reference/arrayFrom.types
const inputARand = getEither(inputA, inputALike);
>inputARand : ArrayLike<A> | Iterable<A>
>getEither(inputA, inputALike) : ArrayLike<A> | Iterable<A>
>getEither : <T>(in1: Iterable<T>, in2: ArrayLike<T>) => Iterable<T> | ArrayLike<T>

@Kingwl Wenlu Wang (Kingwl) Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know why they swapped

@Kingwl

Wenlu Wang (Kingwl) commented Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

Mohamed Hegazy (@mhegazy) Daniel Rosenwasser (@DanielRosenwasser)
review need please😢

@Kingwl

Wenlu Wang (Kingwl) commented May 5, 2018

Copy link
Copy Markdown
Contributor Author

friendly ping 😂

@whtsky

Wu Haotian (whtsky) commented May 5, 2018

Copy link
Copy Markdown

this pr is very helpful to me

@mhegazy

Mohamed Hegazy (mhegazy) commented May 9, 2018

Copy link
Copy Markdown
Contributor

I do not think void is the right type. void means the absence of a return type. it should only be used as a return type for a function.
Now for the original issue. i think we need to have a holistic approach to this issue. there are a few problems here that need to be addressed.. first undefined and missing distinction (see #13195). second, what does that mean in the context of tuple types (since ideally all parameter lists can be transformed to a tuple tuple, and vice versa), and any thing we do in this space needs to either enable or at least not conflict with variadic types (see #5453)

@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 31, 2018
@Kingwl
Wenlu Wang (Kingwl) deleted the improve-void branch August 9, 2018 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kingwl @whtsky @mhegazy