Repository navigation
WIP: ignore last void parameters - #20570
Closed
Wenlu Wang (Kingwl) wants to merge 1 commit into
Closed
Wenlu Wang (Kingwl) wants to merge 1 commit into
Wenlu Wang (Kingwl) wants to merge 1 commit into
Conversation
Ryan Cavanaugh (RyanCavanaugh)
requested changes
Dec 8, 2017
| // Record a new minimum argument count if this is not an optional parameter | ||
| const isOptionalParameter = param.initializer || param.questionToken || param.dotDotDotToken || | ||
| iife && parameters.length > iife.arguments.length && !param.type || | ||
| iife && parameters.length > iife.arguments.length && !param.type || param.type && param.type.kind === SyntaxKind.VoidKeyword || |
There was a problem hiding this comment.
A real fix here is quite a bit more involved, unfortunately.
This change doesn't fix the linked issue because it's only looking for the exact syntactic form of function f(x: void) (which no one would write) instead of actually detecting the type of the parameter during overload resolution and treating it as optional.
Member
|
At a minimum this needs a testcase that includes the original repro (which uses generics). The code so far isn't in the right place to fix the issue as written. |
Member
|
Do we really have people who want to do this now that we have |
Wenlu Wang (Kingwl)
changed the title
Member
|
Daniel Rosenwasser (@DanielRosenwasser) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4260