Auto import inserts import into a comment

Simon Chan (@yume-chan)

From Simon Chan (@yume-chan) on November 22, 2017 2:8

VSCode Version: Code - Insiders 1.19.0-insider (d294b25, 2017-11-21T06:34:51.660Z)
OS Version: Windows_NT x64 10.0.16299
Extensions: Extensions are disabled

Steps to Reproduce:

Create a new folder
Open in Code
npm i @types/node
Create index.js
Type /// <reference types="node" />
Type setTimeout, select the auto import suggest.

Expected Result:

/// <reference types="node" />

import { setTimeout } from "timers";

setTimeout

Actual Result:

/// <reference types="node" />import { setTimeout } from "timers";



setTimeout

Copied from original issue: microsoft/vscode#38914

This is related to crlf line enedings. Here's the code action we get back for a crlf file:

 "codeActions": [
            {
                "description": "Import 'setTimeout' from \"timers\".",
                "changes": [
                    {
                        "fileName": "c:/source/test/y.js",
                        "textChanges": [
                            {
                                "start": {
                                    "line": 1,
                                    "offset": 33
                                },
                                "end": {
                                    "line": 1,
                                    "offset": 33
                                },
                                "newText": "import { setTimeout } from \"timers\";\r\n\r\n"
                            }
                        ]
                    }
                ]
            }
        ],

With lf line endings, we instead get:

 {
                "description": "Import 'setTimeout' from \"timers\".",
                "changes": [
                    {
                        "fileName": "/Users/matb/projects/san/index.js",
                        "textChanges": [
                            {
                                "start": {
                                    "line": 2,
                                    "offset": 1
                                },
                                "end": {
                                    "line": 2,
                                    "offset": 1
                                },
                                "newText": "import { setTimeout } from \"timers\";\n\n"
                            }
                        ]
                    }
                ]
            }
        ],

From #20292 (comment)

import { read } from "fs";

#!/usr/bin/env node

The case that was quoted in #20293 (comment) appeared on my workstation.

That happened on Windows in a file with LF.

Andrew Casey (@amcasey)

I could swear that Andrew Casey (@amcasey) mentioned noticing this (or something very like it) before and having a fix for it; Am I wrong?

Navigation Menu

Repository navigation

Auto import inserts import into a comment #20293

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Auto import inserts import into a comment #20293

Description

Activity

mjbvz commented on Nov 27, 2017

mhegazy commented on Nov 28, 2017

oliversalzburg commented on Nov 30, 2017

weswigham commented on Nov 30, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions