Use node require for auto imports?

Repo

Using the same project as #19629:

// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
// @ts-check

var vscode = require('vscode');

RelativePat|

Accept the completion for RelativePattern from vscode

Expected
Respects existing module style and adds require:

// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
// @ts-check

var vscode = require('vscode');
var { RelativePattern } = require('vscode');

RelativePattern

Actual
import inserted before everything else in the document:

import { RelativePattern } from 'vscode';

// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
// @ts-check

var vscode = require('vscode');

RelativePattern

Matt Bierner (@mjbvz)

In our case, the feature is really more of an annoyance than anything else and I don't see how that could be solved.

Even if the issues pointed out Matt Bierner (@mjbvz) are resolved, the automatic insertion does not respect code style guidelines to the extent that it would be acceptable.

The quotation marks used are determined by the first string appearing in the current file. These may or may not be what is desired for imports. Although I admit that these should usually be consistent.
As pointed out above, the import statement is placed at potentially invalid locations, an even worse case than pointed out above is when the file contains a shebang:
```
import { read } from "fs";

#!/usr/bin/env node
```
This is now invalid and will not run.
If you were to support require, would it use let, const or var? Regardless, it will be undesirable for someone.
What determines if the line is terminated by a semicolon?

The biggest issue is that this happens out of sight and fails commits and/or builds due to code style violations. Handling this costs far more time than any auto-insertion of a statement would have saved.

IMHO, this should have been implemented through one of those little light bulb quick-actions, instead of auto-inserting the statement during auto-completion.

As pointed out above, the import statement is placed at potentially invalid locations, an even worse case than pointed out above is when the file contains a shebang:

This is a bug that we are fixing. #20293 tracks that.

If you were to support require, would it use let, const or var? Regardless, it will be undesirable for someone.

I suppose const unless your --target is ES5/ES3.

What determines if the line is terminated by a semicolon?

tracked by #18780

The biggest issue is that this happens out of sight and fails commits and/or builds due to code style violations. Handling this costs far more time than any auto-insertion of a statement would have saved.

You can always disable the feature using "typescript.autoImportSuggestions.enabled": false if you so choose.

I suppose const unless your --target is ES5/ES3.

How is this determined in a pure JavaScript context?

You can always disable the feature using "typescript.autoImportSuggestions.enabled": false if you so choose.

I tried that. I put it into my workspace settings. It has no effect. After writing this, I realized that it is probably a user setting, which then worked. So, yay.

I'm actually not too concerned with the implementation details, because I doubt that this could be reasonably implemented without a clear definition of the user's desired code style anyway. I initially reported this as an issue because I was frustrated about this being enabled by default and having a negative impact on productivity (which is probably the opposite of what the feature wants to achieve). I feel this was enabled prematurely.

However, I should have realized earlier that the user settings control this behavior. Then I would have saved me said frustration.

How is this determined in a pure JavaScript context?

Default is ES6, you can change it in jsconfig.json. but again this is my expectation to how the feature would work if implemented.

I'm actually not too concerned with the implementation details, because I doubt that this could be reasonably implemented without a clear definition of the user's desired code style anyway.

That is fair. we have been getting reports for adding configuration for style options like so. I think that is something we will be adding as we go. our preference however is to make it smart enough that it works out of the box, e.g. trying to infer the quote from the current file. or use a standard-compliant pattern that most ppl would find agreeable, e.g. using import syntax. I am sure there will always be more user cases to support, but we will keep chipping at these one feature at a time.

Mohamed Hegazy (@mhegazy)

Hi Mohamed Hegazy (@mhegazy) - in my tsconfig.json, my compilerOptions module is set to "None". I am not using ES6 modules. VsCode is inserting import statements at the top of the file. Should it?

I think it would be great to have a configuration option that generates require statements instead of imports and uses const/var depending on what the project is targeting 👍

Just to add: There are definitely times when both require and import are required within the same project - code on node using require and front-end code using import, so a project-global 'importType' toggle won't be enough in these cases. There needs to be a more granular way of defining which should be used: possibly a regexp for files for each type.

Failing that, at least a way to disable auto import for some files. I'm woking with a Gatsby project at the moment and I'm having to remember to go and change every import for the node-related code.

Could TypeScript auto-import with require() in JS code when tsconfig has "module": "commonjs" and "noEmit": true? I was looking for such a setting in VS Code but found only this issue.

Navigation Menu

Repository navigation

Use node require for auto imports? #20292

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Use node require for auto imports? #20292

Description

Activity

oliversalzburg commented on Nov 28, 2017

mhegazy commented on Nov 28, 2017

oliversalzburg commented on Nov 28, 2017

mhegazy commented on Nov 28, 2017

danmarshall commented on Dec 6, 2017

lumaxis commented on Feb 23, 2018

Undistraction commented on May 3, 2018

nykula commented on Nov 20, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions