Skip to content

Add isIntersecting key to IntersectionObserverEntry #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mohamed Hegazy (mhegazy) merged 4 commits into from
Aug 15, 2017
Merged

Add isIntersecting key to IntersectionObserverEntry #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98d9b37
Add isIntersecting key to IntersectionObserverEntry
Jun 29, 2017
38d1852
Merge branch 'master' into intersection-observer-isIntersecting
mhegazy Aug 15, 2017
7c82228
Merge branch 'master' into intersection-observer-isIntersecting
mhegazy Aug 15, 2017
d3ce551
Fix bad merge
mhegazy Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ interface IDBObjectStoreParameters {
}

interface IntersectionObserverEntryInit {
isIntersecting: boolean;
boundingClientRect?: DOMRectInit;

@Jessidhia Jessica Franco (Jessidhia) Jun 29, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These keys are incorrectly marked as optional; they're required in the spec.

It turns out that the generator script doesn't support required so I fixed this in #271

intersectionRect?: DOMRectInit;
rootBounds?: DOMRectInit;
Expand Down Expand Up @@ -7211,6 +7212,7 @@ interface IntersectionObserverEntry {
readonly rootBounds: ClientRect;
readonly target: Element;
readonly time: number;
readonly isIntersecting: boolean;
}

declare var IntersectionObserverEntry: {
Expand Down
13 changes: 13 additions & 0 deletions inputfiles/addedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1630,6 +1630,19 @@
"flavor": "Web",
"type": "\"beforebegin\" | \"afterbegin\" | \"beforeend\" | \"afterend\""
},
{
"kind": "property",
"interface": "IntersectionObserverEntryInit",
"name": "isIntersecting",
"type": "boolean"
},
{
"kind": "property",
"interface": "IntersectionObserverEntry",
"name": "isIntersecting",
"type": "boolean",
"readonly": true
},
{
"kind": "property",
"interface": "ValidityState",
Expand Down