Repository navigation
Add support for required and nullable to IDL dictionaries - #271
Merged
Mohamed Hegazy (mhegazy) merged 3 commits intoAug 15, 2017
Merged
Mohamed Hegazy (mhegazy) merged 3 commits into
Mohamed Hegazy (mhegazy) merged 3 commits into
Conversation
|
@Kovensky, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the
requiredandnullablekeys when they are specified in IDL dictionaries. Currently, any modifiers are ignored.There is also a
defaultkey often present in dictionary keys, but those look like they would only be useful, TypeScript-wise, for documentation.This is likely a breaking change... but code that would break with this was already incorrect, as IDL specifies those keys as required.