Repository navigation
Fix for unlit materials becoming lit in Unity 2021.x - #120
Merged
Cameron (Cameron-Micka) merged 2 commits intoNov 11, 2022
Merged
Conversation
…ked unlit) in Unity 2021.
Matt Rubinstein (holomatt)
approved these changes
Nov 11, 2022
Cameron (Cameron-Micka)
deleted the
user/cameron-micka/fix-2021-lighting-keyword
branch
December 8, 2022 18:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to fix a regression in #110 that made it so unlit materials when opening in 2021.x+ would become lit until refreshed in the material inspector.
To resolve this the existing
_DirectionalLightproperty is observed as the keyword initializer and materials made in code still are lit correctly.In summary the fix is to use Unity's toggle rather than enum property drawer to handle initializing the keyword. We have a custom inspector for this field, so nothing changes for the end user.
Changes
Verification
Note the unlit shader ball in the Material Gallery looks unlit in 2020 and 2021.