Skip to content

Initial Shader State Fixes - #110

Merged
Cameron (Cameron-Micka) merged 6 commits into
microsoft:mainfrom
Cameron-Micka:user/cameron-micka/shader-state-fixes
Oct 14, 2022
Merged

Cameron (Cameron-Micka) merged 6 commits into
microsoft:mainfrom
Cameron-Micka:user/cameron-micka/shader-state-fixes

Conversation

@Cameron-Micka

@Cameron-Micka Cameron (Cameron-Micka) commented Oct 13, 2022 •

Copy link
Copy Markdown
Member

Overview

This PR fixes two issues.

  1. A more robust way to disable batching when object scale is needed.
  2. Ensures the standard shader has the directional light keyword enabled by default when programmatically used to create a material. (This broke in this PR).

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Materials created programmatically are unlit by default even though "Lit Directional" is specified.

1 participant