Repository navigation
FLAB: Allow transient Playwright journeys in validation-only jobs - #104
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 46e778f9-d964-46b0-bebe-3b6f9f71eb74
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes aligning transient Playwright journey guidance across execution surfaces.
No open issues 🎉
1 file not reviewed
dashboard/workflow-policy.js: Generated file
What changed in this PR
This PR resolves conflicting validation-only instructions by allowing job-owned transient Playwright journeys and runner evidence while preserving restrictions on product edits, existing tests, configuration, authentication helpers, and business-data writes.
Changes:
- Adds shared guidance to dashboard and CLI prompts, including dashboard continuations for existing jobs.
- Aligns packaged and repository agents with transient-journey ownership, retry, cleanup, and permission boundaries.
- Adds prompt and cross-runtime parity checks and documents the exception.
| File | Description |
|---|---|
test/dashboard-server.test.js |
Checks transient-journey permissions in initial and continuation prompts. |
test/agent-rules.test.js |
Checks guidance consistency across execution surfaces. |
templates/fixlab-autofix.agent.md |
Adds bounded transient-journey guidance for initialized agents. |
docs/architecture.md |
Documents the exception and its safety boundaries. |
dashboard/workflow-policy.js |
Defines shared transient Playwright guidance. |
dashboard/server.js |
Applies guidance to validation-only and browser-only prompts and continuations. |
com.github.copilot/agents/fixlab.agent.md |
Aligns the packaged Copilot agent guidance. |
bin/fixlab.js |
Includes shared guidance in read-only CLI prompts. |
agents/fixlab.md |
Aligns the reusable FixLab agent guidance. |
.github/agents/fixlab.agent.md |
Adds the exception to the repository FixLab agent. |
.github/agents/fixlab-autofix.agent.md |
Aligns the repository autofix agent with the template. |
Review effort: Balanced
|
FixLab CI failed and was contained without modifying source. Evidence is retained in the workflow artifacts: https://github.com/MonaDevAI/FixLab/actions/runs/42057451941 |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 46e778f9-d964-46b0-bebe-3b6f9f71eb74
There was a problem hiding this comment.
🟡 Changes recommended
The browser-only prompt omits shared Playwright guidance enforcing configured-directory bounds and preserving reviewed fixtures and authentication helpers.
1 open issue
1 file not reviewed
dashboard/workflow-policy.js: Generated file
Review effort: Balanced
| - Do not edit files other than an authorized transient browser-validation artifact. Do not commit, push, create or update pull requests, or change repository configuration. | ||
| - Use the request to select expected behavior and the focused Playwright journey. Read the profile, browser configuration, fixture and nearest test in one bounded batch; prefer an existing journey or retained script. Inspect implementation only for a concrete missing selector or prerequisite. | ||
| - Do not edit files other than job-owned transient Playwright journeys and runner evidence. Do not commit, push, create or update pull requests, or change repository configuration. | ||
| - Never overwrite pre-existing tests. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 46e778f9-d964-46b0-bebe-3b6f9f71eb74
|
FixLab CI failed and was contained without modifying source. Evidence is retained in the workflow artifacts: https://github.com/MonaDevAI/FixLab/actions/runs/42059911902 |

Problem
Validation-only jobs forbade all edits while requiring missing Playwright journeys.
Change
Permit only job-owned transient journeys/evidence; preserve existing tests, configuration and authentication helpers. Apply the exception to retries. Remove irrelevant PR instructions and repeated output guidance: validation-only prompts are about 22% shorter.
Validation
npm pack --dry-runcontains the required files (86)Final-commit CI, unit/browser suites, Windows containment and CodeQL passed. Local browser checks: 46/46; quality gates and packaging passed. The matching build is installed locally.
Risk
Normal runtime approvals, prior denials, sign-in and data-safety controls remain required. No new runtime/database grants.