Skip to content

FLAB: Allow transient Playwright journeys in validation-only jobs - #104

Merged
MonaDevAI merged 3 commits into
mainfrom
fix/validation-only-transient-journeys
Nov 5, 2026
Merged

MonaDevAI merged 3 commits into
mainfrom
fix/validation-only-transient-journeys

Conversation

@MonaDevAI

@MonaDevAI MonaDevAI commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Validation-only jobs forbade all edits while requiring missing Playwright journeys.

Change

Permit only job-owned transient journeys/evidence; preserve existing tests, configuration and authentication helpers. Apply the exception to retries. Remove irrelevant PR instructions and repeated output guidance: validation-only prompts are about 22% shorter.

Validation

  • Focused tests pass
  • npm pack --dry-run contains the required files (86)
  • Documentation is updated
  • No credentials, tokens, private endpoints, or test data are included

Final-commit CI, unit/browser suites, Windows containment and CodeQL passed. Local browser checks: 46/46; quality gates and packaging passed. The matching build is installed locally.

Risk

Normal runtime approvals, prior denials, sign-in and data-safety controls remain required. No new runtime/database grants.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 46e778f9-d964-46b0-bebe-3b6f9f71eb74
Copilot AI balanced review requested due to automatic review settings November 5, 2026 15:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the changes aligning transient Playwright journey guidance across execution surfaces.

No open issues 🎉

1 file not reviewed
  • dashboard/workflow-policy.js: Generated file
What changed in this PR

This PR resolves conflicting validation-only instructions by allowing job-owned transient Playwright journeys and runner evidence while preserving restrictions on product edits, existing tests, configuration, authentication helpers, and business-data writes.

Changes:

  • Adds shared guidance to dashboard and CLI prompts, including dashboard continuations for existing jobs.
  • Aligns packaged and repository agents with transient-journey ownership, retry, cleanup, and permission boundaries.
  • Adds prompt and cross-runtime parity checks and documents the exception.
File Description
test/​dashboard-server.test.js Checks transient-journey permissions in initial and continuation prompts.
test/​agent-rules.test.js Checks guidance consistency across execution surfaces.
templates/​fixlab-autofix.agent.md Adds bounded transient-journey guidance for initialized agents.
docs/​architecture.md Documents the exception and its safety boundaries.
dashboard/​workflow-policy.js Defines shared transient Playwright guidance.
dashboard/​server.js Applies guidance to validation-only and browser-only prompts and continuations.
com.github.copilot/​agents/​fixlab.agent.md Aligns the packaged Copilot agent guidance.
bin/​fixlab.js Includes shared guidance in read-only CLI prompts.
agents/​fixlab.md Aligns the reusable FixLab agent guidance.
.github/​agents/​fixlab.agent.md Adds the exception to the repository FixLab agent.
.github/​agents/​fixlab-autofix.agent.md Aligns the repository autofix agent with the template.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

FixLab CI failed and was contained without modifying source. Evidence is retained in the workflow artifacts: https://github.com/MonaDevAI/FixLab/actions/runs/42057451941

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 46e778f9-d964-46b0-bebe-3b6f9f71eb74
Copilot AI balanced review requested due to automatic review settings November 5, 2026 15:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The browser-only prompt omits shared Playwright guidance enforcing configured-directory bounds and preserving reviewed fixtures and authentication helpers.

1 open issue
1 file not reviewed
  • dashboard/workflow-policy.js: Generated file

Review effort: Balanced

Comment thread dashboard/server.js
- Do not edit files other than an authorized transient browser-validation artifact. Do not commit, push, create or update pull requests, or change repository configuration.
- Use the request to select expected behavior and the focused Playwright journey. Read the profile, browser configuration, fixture and nearest test in one bounded batch; prefer an existing journey or retained script. Inspect implementation only for a concrete missing selector or prerequisite.
- Do not edit files other than job-owned transient Playwright journeys and runner evidence. Do not commit, push, create or update pull requests, or change repository configuration.
- Never overwrite pre-existing tests.
@MonaDevAI
MonaDevAI marked this pull request as ready for review November 5, 2026 16:01
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 46e778f9-d964-46b0-bebe-3b6f9f71eb74
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

FixLab CI failed and was contained without modifying source. Evidence is retained in the workflow artifacts: https://github.com/MonaDevAI/FixLab/actions/runs/42059911902

Copilot AI balanced review requested due to automatic review settings November 5, 2026 16:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the transient Playwright journey guidance changes.

1 open issue
1 file not reviewed
  • dashboard/workflow-policy.js: Generated file

Review effort: Balanced

@MonaDevAI
MonaDevAI merged commit e43010d into main Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants