Skip to content

Fix resizing issue in Split View on El Capitan #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
splhack merged 1 commit into from
Oct 29, 2015
Merged

Fix resizing issue in Split View on El Capitan #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/MacVim/MMWindowController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,6 +1567,12 @@ - (void)updateToolbar

- (BOOL)maximizeWindow:(int)options
{
if (floor(NSAppKitVersionNumber) > NSAppKitVersionNumber10_10_Max) {

@datalogics-kam datalogics-kam Oct 28, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically fixes the problem for me, running on El Capitan. Thanks!

I'm wondering if this conditional should also check to see if the window is actually in split mode.

So far, everything I've tried has worked, even old-style full-screen mode. But I'm wondering if some non-split-screen call to maximizeWindow really does want the code below.

@splhack splhack Oct 28, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had exactly the same thought about that. However I couldn't find any situation that the code is needed on El Capitan. If you find anything, please feel free to create issues.

// NOTE: Prevent to resize the window in Split View on El Capitan or
// later.
return NO;
}

int currRows, currColumns;
[[vimView textView] getMaxRows:&currRows columns:&currColumns];

Expand Down