Skip to content

Fix resizing issue in Split View on El Capitan - #103

Merged
splhack merged 1 commit into
masterfrom
fix/el-capitan-split-view-resize
Oct 29, 2015
Merged

splhack merged 1 commit into
masterfrom
fix/el-capitan-split-view-resize

Conversation

@splhack

@splhack splhack commented Oct 28, 2015

Copy link
Copy Markdown
Contributor

Fix #93

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically fixes the problem for me, running on El Capitan. Thanks!

I'm wondering if this conditional should also check to see if the window is actually in split mode.

So far, everything I've tried has worked, even old-style full-screen mode. But I'm wondering if some non-split-screen call to maximizeWindow really does want the code below.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had exactly the same thought about that. However I couldn't find any situation that the code is needed on El Capitan. If you find anything, please feel free to create issues.

@jpetrie

jpetrie commented Oct 29, 2015

Copy link
Copy Markdown
Contributor

👍

This looks good and works for me locally as well.

@kamitchell

Copy link
Copy Markdown

(At home now) Built this myself, and it looks good to me.

The other problems with MacVim having redraw problems after resizing the El Capitan full-screen split seem to be unrelated, and for some reason don't always occur. I'll start working with a development version of my own and see if I can puzzle out some of the rare issues.

splhack added a commit that referenced this pull request Oct 29, 2015
Fix resizing issue in Split View on El Capitan
@splhack
splhack merged commit 383be18 into master Oct 29, 2015
@splhack
splhack deleted the fix/el-capitan-split-view-resize branch October 29, 2015 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants