Skip to content

Finish up #129 BOLT 7 compliance - #150

Merged
TheBlueMatt merged 10 commits into
lightningdevkit:masterfrom
TheBlueMatt:2018-09-bolt7-compliance
Sep 5, 2018
Merged

TheBlueMatt merged 10 commits into
lightningdevkit:masterfrom
TheBlueMatt:2018-09-bolt7-compliance

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Collaborator

Base on #147 this should close out BOLT 7 on #129 "with the exception of 0.1-tagged open issues" assuming lightning/bolts#474 and lightning/bolts#471 go through.

TheBlueMatt and others added 10 commits September 4, 2018 20:19
Original macro is from Antoine Riard <ariard@student.42.fr>,
the error type and additional mappings are from
Matt Corallo <git@bluematt.me>
Original version is from Antoine Riard <ariard@student.42.fr>,
the error type and some return type fixes are from
Matt Corallo <git@bluematt.me>
They are all just "its too early/late to get an announcement"
errors so simply ignoring them and not sending an announce is fine
Because we've separated out channel closure from ErrorMessage
returning we can return error messages in a few additional cases,
like if the peer sent us a message for a channel they didn't own.
Mostly to add a big comment noting why we aren't "spec-compliant"
@TheBlueMatt
TheBlueMatt merged commit 2a93f98 into lightningdevkit:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant