Skip to content

Work through each BOLT and fill out error conditions #129

Closed

Description

@TheBlueMatt

Need to make sure we're compliant with all the various actions we're supposed to take as specified in the BOLTs, as well as ensure ErrorActions are always Some() in HandleError. Some of these should be pretty easy, some will be way more involved.

  • BOLT 1
  • BOLT 2
  • BOLT 3
  • BOLT 4
  • BOLT 5
  • BOLT 7
  • BOLT 8
  • BOLT 9

BOLT 10 we don't have any implementation of yet (#58), and BOLT 11 is in rust-lightning-invoice.

Activity

  1. TheBlueMatt commented on Aug 25, 2018

    @TheBlueMatt
    CollaboratorAuthor

    I think we're already good on BOLT 8 as there aren't really any "requirements" in it aside from the crypto spec, which we handle fine, and any errors result in disconnection, which I believe is correct.

  2. added this to the 0.1 milestone on Aug 30, 2018
  3. TheBlueMatt commented on Aug 31, 2018

    @TheBlueMatt
    CollaboratorAuthor

    AFAICT, BOLT 3 stuff is all correct, again there aren't many requirements there just a list of scripts and tx formats, all of which should pretty immediately result in failing to send signatures to channel peers, but I read through it again as well and didnt see anything obvious.

  4. TheBlueMatt commented on Sep 3, 2018

    @TheBlueMatt
    CollaboratorAuthor

    Lol, github got a bit overeager, sadly.

  5. added a commit that references this issue on Sep 5, 2018
  6. TheBlueMatt commented on Sep 5, 2018

    @TheBlueMatt
    CollaboratorAuthor

    Yay BOLT 7!

  7. TheBlueMatt commented on Nov 1, 2018

    @TheBlueMatt
    CollaboratorAuthor

    Technically we know about all the various flags, even if we dont implement all the optional ones (see #236) so BOLT 9 is "implemented".

  8. added a commit that references this issue on Nov 23, 2018
  9. ariard commented on Jul 29, 2019

    @ariard

    @rrybarczyk, this one should be a good first issue if you're looking for something to hack on, and nice to understand the whole procotol :)

    (generally moar tests are always well welcomed)

  10. moved this from Todo to In Progress in LDK Roadmapon Dec 7, 2021
  11. TheBlueMatt commented on May 5, 2024

    @TheBlueMatt
    CollaboratorAuthor

    ErrorAction has been required for quite some time.

  12. moved this from In Progress to Done in LDK Roadmapon May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions