You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Work through each BOLT and fill out error conditions #129
Need to make sure we're compliant with all the various actions we're supposed to take as specified in the BOLTs, as well as ensure ErrorActions are always Some() in HandleError. Some of these should be pretty easy, some will be way more involved.
BOLT 1
BOLT 2
BOLT 3
BOLT 4
BOLT 5
BOLT 7
BOLT 8
BOLT 9
BOLT 10 we don't have any implementation of yet (#58), and BOLT 11 is in rust-lightning-invoice.
I think we're already good on BOLT 8 as there aren't really any "requirements" in it aside from the crypto spec, which we handle fine, and any errors result in disconnection, which I believe is correct.
AFAICT, BOLT 3 stuff is all correct, again there aren't many requirements there just a list of scripts and tx formats, all of which should pretty immediately result in failing to send signatures to channel peers, but I read through it again as well and didnt see anything obvious.
Activity
TheBlueMatt commentedon Aug 25, 2018
I think we're already good on BOLT 8 as there aren't really any "requirements" in it aside from the crypto spec, which we handle fine, and any errors result in disconnection, which I believe is correct.
TheBlueMatt commentedon Aug 31, 2018
AFAICT, BOLT 3 stuff is all correct, again there aren't many requirements there just a list of scripts and tx formats, all of which should pretty immediately result in failing to send signatures to channel peers, but I read through it again as well and didnt see anything obvious.
TheBlueMatt commentedon Sep 3, 2018
Lol, github got a bit overeager, sadly.
Merge pull request #150 from TheBlueMatt/2018-09-bolt7-compliance
TheBlueMatt commentedon Sep 5, 2018
Yay BOLT 7!
TheBlueMatt commentedon Nov 1, 2018
Technically we know about all the various flags, even if we dont implement all the optional ones (see #236) so BOLT 9 is "implemented".
Merge branch 'master' into philip-lightningdevkit#129-bolt4-packet-fo…
ariard commentedon Jul 29, 2019
@rrybarczyk, this one should be a good first issue if you're looking for something to hack on, and nice to understand the whole procotol :)
(generally moar tests are always well welcomed)
TheBlueMatt commentedon May 5, 2024
ErrorActionhas been required for quite some time.