Skip to content

support dynamic versions ending with + - #170

Merged
holgerbrandl merged 2 commits into
kscripting:masterfrom
NikkyAI:master
Sep 27, 2018
Merged

holgerbrandl merged 2 commits into
kscripting:masterfrom
NikkyAI:master

Conversation

@NikkyAI

@NikkyAI NikkyAI commented Sep 26, 2018 •

Copy link
Copy Markdown
Contributor

for maven these are wrappend in a range
1.2.3+ -> [1.2.3,)

for gradle they are not touched and just passed as is

closes #166

improve parsing of DEPS_ANNOTATION
assume there is no more `)` after the annotation
fixes kscripting#166
@NikkyAI NikkyAI changed the title support versions ending with + support dynamic versions ending with + Sep 26, 2018
@NikkyAI

NikkyAI commented Sep 26, 2018

Copy link
Copy Markdown
Contributor Author

this replaces #169

@holgerbrandl
holgerbrandl merged commit e9ff3da into kscripting:master Sep 27, 2018
@holgerbrandl

Copy link
Copy Markdown
Collaborator

Thanks @NikkyAI for this beautiful PR, especially since it even contained unit and shell integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependency notation does not support maven version range syntax containing ) and ,

2 participants