Skip to content

fix maven open version ranges - #169

Closed
NikkyAI wants to merge 2 commits into
kscripting:masterfrom
NikkyAI:master
Closed

NikkyAI wants to merge 2 commits into
kscripting:masterfrom
NikkyAI:master

Conversation

@NikkyAI

@NikkyAI NikkyAI commented Sep 26, 2018 •

Copy link
Copy Markdown
Contributor

specifying [1.0) as version was broken, because kscript would not pass the correct values to the POM

disallow , in DEPS_COMMENT
; and space should still work

improve parsing of DEPS_ANNOT
use .substringBeforeLast(")")instead of .split(")")[0]
assume there is no more ) after the annotation
maybe also make sure //.+ is stripped before?

is there no smarter annotation parser available ?

fixes #166

disallow `,` in DEPS_COMMENT
improve parsing of DEPS_ANNOT
assume there is no more `)` after the annotation
fixes kscripting#166
@NikkyAI

NikkyAI commented Sep 26, 2018

Copy link
Copy Markdown
Contributor Author

it has become obvious to me this attempt is fighting windmills,
the range notation would have to be converted to gradle (which has less finegraned control, so it would be lossy)
also we cannot fix the //DEPS comment in fear of breaking old code

i will open a new PR
where i will instead convert gradle's + (and pretty much only that) to maven ranges
since supporting the full ranges syntax is impossible (without breaking //DEPS) and this covers most the usecases already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependency notation does not support maven version range syntax containing ) and ,

1 participant