Skip to content

feature: Add credentials to @file:MavenRepository #143

Closed

Description

@MikeMitterer

I'm using Artifactory for my Maven-Repo
In my case the repo needs credentials

Would be cool if I could specify them for @file:MavenRepository

Activity

  1. self-assigned this
    on Jul 28, 2018
  2. holgerbrandl commented on Jul 28, 2018

    @holgerbrandl
    Collaborator

    Is there a public maven repo with credentials support which we could use for testing?

  3. MikeMitterer commented on Jul 31, 2018

    @MikeMitterer
    Author

    Not that I know - can I test something for you?

  4. holgerbrandl commented on Aug 17, 2018

    @holgerbrandl
    Collaborator

    Could you provide an example how the corresponding maven should look like? Currently we simply create them as:

        <repository>
                <id>${it.id}</id>
                <url>${it.url}</url>
        </repository>
    

    See https://github.com/holgerbrandl/kscript/blob/d6e5e87462d8d86dca62e1a9894b7cb457fcaa46/src/main/kotlin/kscript/app/DependencyUtil.kt#L56

    We still need to find a way to unit-test it, otherwise it may break in the future.

  5. holgerbrandl commented on Oct 15, 2018

    @holgerbrandl
    Collaborator

    I'd also think that credentials should better go into config file as described above, but it would be a technically easy to extend the annotation to accept credentials. Doing so would also help to see if #49 could provide a better solution for dependency resolution.

    @ligee Are you planning to add credential support to @file:Repository as used in https://github.com/Kotlin/KEEP/blob/master/proposals/scripting-support.md#script-with-maven-dependencies-resolving-support ?

  6. ligee commented on Oct 19, 2018

    @ligee

    @holgerbrandl I guess that should be addressed in Kotlin scripting at some point. I created an issue to track it https://youtrack.jetbrains.com/issue/KT-27701.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions