Skip to content

get rid of mvn and use jar-dependency to resolve //DEPS #49

Closed

Description

@holgerbrandl

Activity

  1. holgerbrandl commented on Nov 4, 2017

    @holgerbrandl
    CollaboratorAuthor
  2. gildor commented on Nov 6, 2017

    @gildor
    Contributor

    Keplin uses aether under the hood.
    Grape also updated last time 3 years ago, later than Aether but still not under active development.
    Also, even Gradle uses Aether for maven (at least for publication, as I see, but cannot be sure).

    Maybe make sense to ask an advice for someone from Gradle team. But Aether still looks like a good option and better than standalone mvn

  3. holgerbrandl commented on Nov 6, 2017

    @holgerbrandl
    CollaboratorAuthor

    Thanks for the info and the codepointer @gildor.

  4. gildor commented on Nov 6, 2017

    @gildor
    Contributor

    Also, would be good if Aether (or other implementation) could reuse local .m2 cache to prevent dependency downloading only for script

  5. gildor commented on Jan 9, 2018

    @gildor
    Contributor

    @holgerbrandl I've started working on Aether integration in my fork and now have early proof of concept that passes all the tests. I should clean up and probably refactor dependency resolution and tests.

    Did you consider something about this feature? Maybe you have some different plans

    If you still think that this is a good idea I can continue work to have production-ready prototype

  6. holgerbrandl commented on Jan 9, 2018

    @holgerbrandl
    CollaboratorAuthor

    That's really exciting news! We just have to integrate it carefully to avoid breaking user-installations. There are some dependency tests already, but I'm not sure if they really cover the full spectrum of use-cases yet.

    Only considerations from my end

    Never touched but still on the list are also dependency exclusions #12

    How much does the shadow jar grow by adding aether?

  7. gildor commented on Jan 9, 2018

    @gildor
    Contributor

    @holgerbrandl

    maintain option to allow for custom artifact repos

    Yes, custom repos already supported

    maintain artifact download reporting

    I have some logs already, no progress tho, just message about artifact downloading

    dependency exclusions

    Shouldn't be a problem, Aether supports exclusion

    How much does the shadow jar grow by adding aether

    I'm not sure now, currently, I use some third party libs for fast implementation, but I plan to get rid of them and use only minimal set. But will report later

  8. holgerbrandl commented on Jan 9, 2018

    @holgerbrandl
    CollaboratorAuthor

    We don't have detailed logging at the moment. Just something like
    Started downloading log4j_3.2 .... Done
    and so on. See https://github.com/holgerbrandl/kscript/blob/master/src/main/kotlin/kscript/app/DependencyUtil.kt#L116

    Anything more detailed is likely to be more annoying than useful. I just added it to avoid the impression that kscript is stuck, while it is resolving dependencies internally.

  9. andreas-mausch commented on Sep 6, 2018

    @andreas-mausch
    Contributor

    What's the status here? Can I see @gildor's the code somewhere?

  10. andreas-mausch commented on Sep 7, 2018

    @andreas-mausch
    Contributor

    I'm impatient and started an implementation. Tests are green, haven't checked compatibility for the dependency_cache yet tho. See PR #159

  11. holgerbrandl commented on Oct 29, 2018

    @holgerbrandl
    CollaboratorAuthor

    Duplicate of #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions