Skip to content

Remove outdated urllib3<2.0.0 pin (rebase of #92) - #97

Merged
jirkasemmler merged 1 commit into
keboola:masterfrom
stanekjiri:patch-1
Oct 8, 2026
Merged

jirkasemmler merged 1 commit into
keboola:masterfrom
stanekjiri:patch-1

Conversation

@stanekjiri

Copy link
Copy Markdown
Contributor

Rebased version of #92, which resolves the merge conflict that was blocking it.
The original commit is authored by @LukasRada and preserved as-is through the rebase.

Summary

Removes the direct urllib3<2.0.0 constraint from pyproject.toml.

  • The pin was a workaround for boto/botocore#2926, which is resolved and closed.
  • botocore declares its own constraint — urllib3>=1.25.4,<3,!=2.2.0 as of 1.43.109 — so the compatible range is already enforced transitively.
  • kbcstorage does not import urllib3 anywhere; HTTP goes through requests, and retry_requests.py implements its own retry loop rather than using urllib3.util.Retry. The pin is a phantom dependency.
  • As a hard constraint in published metadata it propagates to every consumer, blocking downstream projects from resolving urllib3 2.x and the packages that depend on it.

Conflict resolution

1164636 ("default to key-pair login for snowflake workspaces") added cryptography
on the line directly above the urllib3 pin, which is what put #92 into conflict.

Resolved exactly as requested in #92: kept cryptography, dropped the urllib3 line.
The result is a one-line diff against current master.

Closes #91
Supersedes #92

Removed urllib3 dependency restriction due to issue resolution.
@stanekjiri

Copy link
Copy Markdown
Contributor Author

@jirkasemmler cc

@jirkasemmler
jirkasemmler self-requested a review October 8, 2026 13:28
@jirkasemmler
jirkasemmler merged commit 34745a7 into keboola:master Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove outdated urllib3<2.0.0 constraint

2 participants