Repository navigation
Remove outdated urllib3<2.0.0 pin (rebase of #92) - #97
Merged
Merged
Conversation
Removed urllib3 dependency restriction due to issue resolution.
Contributor
Author
jirkasemmler
self-requested a review
October 8, 2026 13:28
jirkasemmler
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #92, which resolves the merge conflict that was blocking it.
The original commit is authored by @LukasRada and preserved as-is through the rebase.
Summary
Removes the direct
urllib3<2.0.0constraint frompyproject.toml.urllib3>=1.25.4,<3,!=2.2.0as of 1.43.109 — so the compatible range is already enforced transitively.kbcstoragedoes not importurllib3anywhere; HTTP goes throughrequests, andretry_requests.pyimplements its own retry loop rather than usingurllib3.util.Retry. The pin is a phantom dependency.Conflict resolution
1164636 ("default to key-pair login for snowflake workspaces") added
cryptographyon the line directly above the urllib3 pin, which is what put #92 into conflict.
Resolved exactly as requested in #92: kept
cryptography, dropped the urllib3 line.The result is a one-line diff against current
master.Closes #91
Supersedes #92