Repository navigation
Conversation
The direct urllib3<2.0.0 constraint was added as a workaround for boto/botocore#2926, which has since been resolved. Current botocore manages its own urllib3 version constraints via Python version markers. kbcstorage does not import or use urllib3 directly, so the pin is unnecessary and blocks downstream projects from upgrading. Closes keboola#91
Contributor
|
Thanks for the PR! The urllib3 pin removal itself looks good and we'll approve it. However, the branch is currently in conflict with |
jirkasemmler
added a commit
that referenced
this pull request
Oct 8, 2026
Remove outdated urllib3<2.0.0 pin (rebase of #92)
Contributor
|
closing as it has been fixed in #97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urllib3<2.0.0constraint frompyproject.tomlurllib3<1.27for Python <3.10,urllib3>=1.25.4,<3for Python >=3.10)Closes #91