Repository navigation
Conversation
|
We can avoid changing the method signatures by wrapping the /** Exception occurred in native code **/
final public static String TYPE_NATIVE_EXCEPTION = "Native exception occurred: %s";
// ...
public static SerialPortException wrapNativeException(Exception e, SerialPort port, String methodName) {
return new SerialPortException(port, methodName, String.format(TYPE_NATIVE_EXCEPTION, e.getLocalizedMessage()));
} public boolean writeBytes(byte[] buffer) throws SerialPortException {
checkPortOpened("writeBytes()");
boolean success;
try {
success = serialInterface.writeBytes(portHandle, buffer);
} catch(IOException io) {
throw SerialPortException.wrapNativeException(io, this, "writeBytes");
}
return success;
} |
tresf
self-requested a review
November 8, 2023 18:32
tresf
approved these changes
Nov 8, 2023
hiddenalpha
deleted the
report-write-bytes-errors-as-exceptions-20231108
branch
November 9, 2023 01:05
hiddenalpha
restored the
report-write-bytes-errors-as-exceptions-20231108
branch
February 16, 2024 20:53
hiddenalpha
deleted the
report-write-bytes-errors-as-exceptions-20231108
branch
November 23, 2024 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.