Repository navigation
Throw exception in case we fail to getBuffersBytesCount - #138
Merged
tresf merged 3 commits intoNov 9, 2023
Merged
Conversation
NOTE 1: Initially I did like to throw java.io.IOException. But as
interface does not declare any exception this would require a change
in the signature (aka declare that it throws an exception).
NOTE 2: "Compiles on my machine". I could NOT meaningfully test this
code as I've neither a setup where I could test it, nor have I
enough time to do it.
Relates to: #125
(wip @ d4da2040382f9836b1d1a0c5fd706a8283a86e64)
tresf
self-requested a review
May 1, 2023 14:56
|
I think a signature change is fine, but code which doesn't immediately require a signature change is also a nice stop-gap. |
tresf
approved these changes
May 1, 2023
If you like my proposal in #146 (comment), we can maintain our signatures but also raise the exception. |
tresf
reviewed
Nov 8, 2023
…til we really need it. (wip @ 5c52479)
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I did like to throw java.io.IOException. But as interface does not declare any exception this would require a change in the signature (aka declare that it throws an exception). Let me know if we should throw something else than what I've chosen.
Relates to: #125