Skip to content

Record the deployed R2 bucket name - #31

Merged
itsryanarmani merged 2 commits into
mainfrom
parab/turbo-cache-deploy
Aug 27, 2026
Merged

itsryanarmani merged 2 commits into
mainfrom
parab/turbo-cache-deploy

Conversation

@itsryanarmani

@itsryanarmani itsryanarmani commented Aug 27, 2026 •

Copy link
Copy Markdown
Owner

What

wrangler.jsonc carried YOUR_R2_BUCKET_NAME, which wrangler rejects outright — bucket names must be lowercase alphanumeric with hyphens, so the placeholder itself fails validation before it ever reaches the API. Replaced with the real bucket.

The cache is live

Deployed to https://turbo-remote-cache.hello-fd1.workers.dev, backed by the turbo-remote-cache R2 bucket. Verified end to end against the live deployment:

Check Result
no token 401
wrong token 401
/v8/artifacts/status {"status":"enabled"}
PUT then GET round-trips
x-artifact-tag preserved
missing hash 404
?teamId=../../other 400
same hash, different team 404

The last two are the traversal fix and team isolation working against the real Worker, not just the test mock.

Wiring

TURBO_TOKEN (secret) plus TURBO_API and TURBO_TEAM (variables) are set on all 14 private repos that use turbo. Three of the four repos whose CI invokes turbo directly now read them — content-rabbit #894, replytosocial #196, supportsheep #53. popcornteam is last, deliberately: it has three open PRs touching ci.yml and a fourth would conflict with all of them.

Summary by CodeRabbit

  • Documentation

    • Clarified that the shared remote cache bucket is already configured.
    • Added guidance for deploying a personal instance, including creating a bucket and updating its name.
    • Removed outdated placeholder replacement instructions.
  • Configuration

    • Updated remote cache deployment settings to use the configured bucket directly.
    • Added clearer generated-configuration guidance.

The placeholder had to be replaced before deploy, and leaving it in means the
next person repeats the same failed `wrangler r2 bucket create` against an
invalid name. The bucket and the Worker are both live.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e701c71-7b8f-4315-9bac-606e2df2ab9c

📥 Commits

Reviewing files that changed from the base of the PR and between db2b52d and 8d93b0f.

📒 Files selected for processing (2)
  • turbo-remote-cache/README.md
  • turbo-remote-cache/wrangler.jsonc

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The R2 configuration now uses the turbo-remote-cache bucket. The setup documentation distinguishes shared bucket usage from self-hosted deployments.

Changes

R2 bucket setup

Layer / File(s) Summary
Bucket configuration and setup
turbo-remote-cache/wrangler.jsonc, turbo-remote-cache/README.md
Wrangler now names the turbo-remote-cache bucket. The README documents the shared bucket and self-hosted bucket_name setup.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 8d93b

This localized change records the deployed R2 bucket configuration and documentation; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: recording the deployed R2 bucket name in the Wrangler configuration and related setup instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch parab/turbo-cache-deploy

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, low-risk PR: replaces the YOUR_R2_BUCKET_NAME placeholder in wrangler.jsonc with the real, deployed bucket name (turbo-remote-cache). PR description documents end-to-end verification against the live Worker (auth, round-trip, path-traversal, team isolation), which covers the security-sensitive paths touched by prior PR #30.

Found & fixed: README.md's Setup step 1 still said "The placeholder is intentional — do not commit a real bucket name until you own it," which directly contradicted the bucket name this PR just committed. Left as-is, the next person reading Setup would be confused about whether the committed name was accidental. Updated the README to explain the current state (shared deployed bucket) and clarify the fork/own-instance case. Pushed as 8d93b0f.

No other issues found — the diff itself is two lines and doesn't touch runtime code, auth, or the hash/path validation logic.

🧑‍⚖️ Council
Model Lens Result
GPT-5.6 (Codex) correctness no findings (API error: insufficient quota, HTTP 429)
Gemini 3 Pro performance no findings (API error: spend cap exceeded, HTTP 429)
Kimi K3 security no findings (API error: account suspended, HTTP 429)
Grok 4.5 maintainability no findings

All three paid-API council members failed with billing/quota errors before producing any review content, so this review is based on the chair's own read plus Grok's pass, not verified multi-lens council input.

"

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Small, low-risk change: records the real deployed R2 bucket name (turbo-remote-cache) in wrangler.jsonc in place of the earlier placeholder, and updates the README setup instructions to match. No logic changes.

Checked for:

  • Stale references — no leftover mentions of YOUR_R2_BUCKET_NAME anywhere in the package (grepped src/, package.json, lockfile, wrangler config).
  • Security — the bucket name itself is not a secret; the Worker still requires a TURBO_TOKEN bearer auth (timing-safe compare, per README's own security notes) to reach any R2 object, and R2 buckets aren't publicly reachable without separate public-access config. Recording the real name here appears to be an intentional decision (see commit "Record the deployed R2 bucket name"), not an accidental leak.
  • Test coverage — no tests reference the bucket name; nothing to update there.
  • Docs consistency — README's new wording ("already points bucket_name at ... the bucket backing the deployed instance for this org") accurately matches wrangler.jsonc.

No Critical/Major/Minor findings. No fixes pushed this cycle.

🧑‍⚖️ Council
Model Lens Result
GPT-5.6 (Codex) correctness no findings (API error: insufficient quota — review did not run)
Gemini 3 Pro performance no findings (API error: monthly spend cap exceeded — review did not run)
Kimi K3 security no findings (API error: account suspended/insufficient balance — review did not run)
Grok 4.5 maintainability no findings

Note: three of four council lenses failed to execute due to provider-side billing/quota errors, so this review leans more heavily on the synthesizer's own pass (diff read, grep for stale references, README/config consistency, test coverage) than usual. Nothing in that pass turned up a confirmed issue, but flagging the reduced lens coverage for transparency.

@itsryanarmani
itsryanarmani merged commit 6b74c24 into main Aug 27, 2026
2 checks passed
@itsryanarmani
itsryanarmani deleted the parab/turbo-cache-deploy branch August 27, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant