Skip to content

[SCR-195] Package the issue-standard templates - #196

Merged
itsryanarmani merged 4 commits into
mainfrom
scr-195-package-the-issue-standard-templates
Sep 2, 2026
Merged

itsryanarmani merged 4 commits into
mainfrom
scr-195-package-the-issue-standard-templates

Conversation

@itsryanarmani

Copy link
Copy Markdown
Owner

Closes #195

What

Packages the issue-standard templates beside pr-standards-templates/: the four issue forms, config.yml, the AGENTS.md marker block, and a .agents/issues.md stub.

Why

The rollout in #183 needs something to roll out. content-rabbit adopted the standard in pooriaarab/content-rabbit#1205, and those files were reachable from nowhere else.

The forms and config.yml are the reviewed and merged files, copied rather than rewritten, so the fleet gets what was actually looked at rather than a second draft of it.

.agents/issues.md is the one that cannot be copied. It names the repo's analytics helper and its high-stakes paths, and neither can be derived from outside that repo. Inventing them would put a confident wrong answer into 88 places, which is worse than an empty one, because an agent believes it. So it ships as a stub: the parts that are identical everywhere are verbatim, the parts that are not are TODOs, and the first line says it must be filled in before it is useful.

How I verified

The forms still satisfy the checker that will judge issues filed through them:

issue-standards lint --dir issue-standards-templates
  -> PASS bug.yml
     PASS feature.yml
     PASS chore.yml
     PASS epic.yml
     OK

Run with the checker from #192, because lint is not on main yet: only precheck is. On main today the same command reports an unknown mode, which is correct and not a failure of these files.

The stub names no repo but the one it is dropped into:

grep -niE "content.rabbit|posthog|trackEvent|staging database" issues.md.stub
  -> no matches

That grep found four leaks on the first draft, which is why it is written down here: the source file it was derived from is content-rabbit's, and the repo-specific parts do not announce themselves.

Size:

git diff --stat origin/main
  -> 7 files changed, 451 insertions(+)

Not in this PR

issue-standards-rollout, the program that reads these and plans a repo. It is #183, split out because the two together are 614 counted lines and the cap is 500. The cap forced the split, which is what it is for.

How it was built

The stub was drafted by a muse worker from content-rabbit's file. Review caught four repo-specific leaks it had carried over, including a line about test users and the staging database that is true only for content-rabbit, and a claim that sub-issues were "verified against the API" for a repo nobody had checked. Those are the exact failure this stub exists to prevent, so they are worth naming rather than quietly fixing.

Assisted-by: claude-personal-1:claude-opus-5

The rollout needs something to roll out. content-rabbit adopted the
standard in its own repo and those files were reachable from nowhere
else.

Package them beside pr-standards-templates, which already works this
way. The four forms and config.yml are the reviewed and merged files,
copied rather than rewritten, so the fleet gets what was actually
looked at.

.agents/issues.md is the one that cannot be copied. It names the
repo's analytics helper and its high-stakes paths, and neither can be
derived from outside that repo. Inventing them would put a confident
wrong answer into 88 places, so it ships as a stub carrying the parts
that are identical everywhere and TODOs for the parts that are not.
Its first line says it must be filled in before it is useful.
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 106 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 74af8825-403d-48b8-81ad-ca75630f1042

📥 Commits

Reviewing files that changed from the base of the PR and between f110f34 and fb83c6a.

📒 Files selected for processing (7)
  • issue-standards-templates/agents-block.md
  • issue-standards-templates/bug.yml
  • issue-standards-templates/chore.yml
  • issue-standards-templates/config.yml
  • issue-standards-templates/epic.yml
  • issue-standards-templates/feature.yml
  • issue-standards-templates/issues.md.stub

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Council review

Verified the one confirmed finding from council against the code (correctness, performance, security, and maintainability lenses returned nothing). No fixes pushed this round — see loop-guard note below.

Confirmed (Major): issue-standards-templates/bug.yml:44 still hardcodes the content-rabbit test workspace pooriaarabtestgrowth in the Environment field's placeholder. This is the same class of leak this PR has already fixed twice (repo links/analytics in 7998273, the d3k errors tool name in fb83c6a), but this instance survived both passes because the PR's own leak-check grep (grep -niE "content.rabbit|posthog|trackEvent|staging database" issues.md.stub) only scans issues.md.stub, not the rest of issue-standards-templates/. I confirmed it's still there and that no other file in the directory carries a similar leak.

I did not push a fix: this PR has already gone through 3 automated fix cycles and push access for this run is disabled, so this needs a human to (a) replace the placeholder with a generic value (e.g. Chrome 141, Growth plan, acme-marketing, staging) and (b) widen the verification grep to the whole issue-standards-templates/ directory so this class of leak stops slipping through one file at a time.

Other lenses checked and cleared:

  • PR-standard compliance (.github/pr-standards.json present): branch scr-195-package-the-issue-standard-templates, title [SCR-195] Package the issue-standard templates, body has exactly one Closes #195, ## What/## Why/## How I verified, ends in Assisted-by:. 453 counted lines / 7 files, well under the 500-line / 40-file caps. No violations.
  • Proof lens: the PR claims issue-standards lint --dir issue-standards-templates passes for all four forms using the checker from #192 (not yet on this branch's base, since lint mode didn't exist there — the PR body is upfront about this). #192 has since merged to main with real lint support, so I checked its logic directly: lintTemplates() only compares each form's label: fields against required headings, and none of the three follow-up fix commits touched a label: line (only description:/prose text), so the PASS claim still holds today. I manually traced all four forms' field labels against REQUIRED_HEADINGS/FORBIDDEN_HEADINGS in issue-standards.mjs and confirmed each form provides exactly the required headings (epic correctly omits Acceptance criteria). The stub leak-check grep reproduces with no matches, confirming that specific claim — it just doesn't cover the file where the leak actually is (see above).
  • No test-coverage gap: this PR adds only template/markdown assets, no executable logic, so unit tests aren't applicable here.
🧑‍⚖️ Council
Model Lens Result
GPT-5.6 (Codex) correctness no findings
Gemini 3 Pro performance no findings
Kimi K3 security no findings
Grok 4.5 maintainability no findings
GPT-5.6 (scope) scope confirmed — pooriaarabtestgrowth leak in bug.yml:44

attributes:
label: Environment
description: Browser, plan, workspace, and whether this is local, staging or production.
placeholder: Chrome 141, Growth plan, pooriaarabtestgrowth, staging

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major — repo-specific leak survives two prior cleanup passes. This placeholder still names the content-rabbit test workspace pooriaarabtestgrowth. This PR's own "How I verified" leak-check grep only scans issues.md.stub, so it never touched this file. Please replace with a generic placeholder (e.g. acme-marketing) and widen the verification grep to cover all of issue-standards-templates/, not just the stub. Not pushing a fix here: this PR has already had 3 automated fix cycles and push is disabled for this run.

@itsryanarmani
itsryanarmani merged commit 699dd05 into main Sep 2, 2026
4 checks passed
@itsryanarmani
itsryanarmani deleted the scr-195-package-the-issue-standard-templates branch September 2, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package the issue-standard templates

1 participant