Repository navigation
Conversation
No behavior change. The create/replace/skip choice now lives in action/src/comment.ts so it can be unit-tested with node --test.
When neither the new build nor the previous bot comment has a warning, the bot used to stay silent, leaving the old comment pointing at a stale run. It now edits that comment in place with the fresh table, so the links always jump to the latest run while still not notifying anyone. Fixes #24
An object literal with only an id has no property in common with CommentLike, so tsc rejected it (TS2559). Neither the Rollup build nor node --test type-checks the test file, which is why it went unnoticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #24