Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

tests: harden old instance cleanup against NotFound - #471

Merged
larkee merged 1 commit into
masterfrom
435-436-437-samples-unflake
Jul 29, 2021
Merged

larkee merged 1 commit into
masterfrom
435-436-437-samples-unflake

Conversation

@tseaver

@tseaver tseaver commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

Toward #435, #436, #437.

Note on CI: we seem to be in a mode currently where the service account used for CI is quota-starved for some operations (instance admin, at least). All this PR does is remove an early failure in the samples, where different jobs race to do the cleanup of old instances before beginning the actual sample run.

@tseaver
tseaver requested review from a team and larkee July 29, 2021 20:01
@tseaver
tseaver requested a review from a team as a code owner July 29, 2021 20:01
@tseaver
tseaver requested review from leahecole and removed request for a team July 29, 2021 20:01
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 29, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 29, 2021
@tseaver tseaver added the samples Issues that are directly related to samples. label Jul 29, 2021
@larkee
larkee merged commit 93c09ab into master Jul 29, 2021
@larkee
larkee deleted the 435-436-437-samples-unflake branch July 29, 2021 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants