[tswast]

Closes #5441

[theacodes]

Could you try using sys.platform != windows in the extras in setup.py?

[tswast]

Could you try using sys.platform != windows in the extras in setup.py?

We don't want to exclude all Windows installs, just those for Python 2.7. Do platform-specific dependencies "and" together?

[theacodes]

yes

…

On Tue, Jun 5, 2018 at 2:21 PM Tim Swast ***@***.***> wrote: Could you try using sys.platform != windows in the extras in setup.py? We don't want to exclude all Windows installs, just those for Python 2.7. Do platform-specific dependencies <http://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-platform-specific-dependencies> "and" together? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5442 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc0-R7rDPsvqkKezUS3FQaCT2CK2Gks5t5vZOgaJpZM4UbkEX> .

[tswast]

Hmm, I guess extras_require doesn't allow exclusions? I tried

extras = {
    'pandas': 'pandas>=0.17.1',
    # Exclude PyArrow dependency from Windows Python 2.7.
    'pyarrow': 'pyarrow>=0.4.1; platform_system!=Windows or python_version>2.7',
}

and got "error in google-cloud-bigquery setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers."

[theacodes]

Does it work with just one platform specifier?

…

On Tue, Jun 5, 2018 at 2:57 PM Tim Swast ***@***.***> wrote: Hmm, I guess extras_require doesn't allow exclusions? I tried extras = { 'pandas': 'pandas>=0.17.1', # Exclude PyArrow dependency from Windows Python 2.7. 'pyarrow': 'pyarrow>=0.4.1; platform_system!=Windows or python_version>2.7', } and got "error in google-cloud-bigquery setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers." — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5442 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc8n5LA4L6x8sB_GHM7t6hgSmdsVvks5t5v7DgaJpZM4UbkEX> .

[tswast]

Update: the syntax is different than I expected, but I still haven't figured out how to and/or multiple markers.

extras = {
    'pandas': 'pandas>=0.17.1',
    # Exclude PyArrow dependency from Windows Python 2.7.
    'pyarrow: platform_system!=Windows or python_version>2.7': 'pyarrow>=0.4.1',
}

"error in google-cloud-bigquery setup command: Invalid environment marker: platform_system!=Windows or python_version>2.7"

[theacodes]

https://www.python.org/dev/peps/pep-0496/#examples

…

On Tue, Jun 5, 2018 at 3:01 PM Tim Swast ***@***.***> wrote: Update: the syntax is different than I expected, but I still haven't figured out how to and/or multiple markers. extras = { 'pandas': 'pandas>=0.17.1', # Exclude PyArrow dependency from Windows Python 2.7. 'pyarrow: platform_system!=Windows or python_version>2.7': 'pyarrow>=0.4.1', } "error in google-cloud-bigquery setup command: Invalid environment marker: platform_system!=Windows or python_version>2.7" — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#5442 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc5r_lmvfkD6IOrRKVC8yNovPpLiQks5t5v_JgaJpZM4UbkEX> .

[tswast]

I've confirmed that the previously failing unit tests pass on my Windows machine.