Repository navigation
Make 'Client.list_instances' return actual instance objects, not protos. - #5420
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
@theacodes The Appveyor failure here is the known Pandas + PyArrow + Python 2.7 problem in BigQuery (#5441, solved via PR #5442). Rather than rebase and force CI to run again, I'd like to just merge here on the strength of the CircleCI green. |
theacodes
approved these changes
Jun 7, 2018
Contributor
|
That's fine, but I'd like @sduskis to take a look first. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @aneepct @sduskis