Repository navigation
gcloud.storage.bucket.Bucket.save_default_object_acl with empty ACL doesn't clear #139
Description
The following test:
acl = acl or self.default_object_acl
should test for None instead:
if acl is None:
acl = self.default_object_acl
This bug prevents 'clear_default_object_acl' from working (calling it just saves the existing ACL).
Activity
dhermes commentedon Sep 18, 2014
Can you link to source in these bugs?
For example, the relevant line for this bug along with the commit where it's relevant (can get it by pressing
ywhile in the GitHub UI).This will make bugs easier to track as the code changes underneath.
tseaver commentedon Sep 18, 2014
https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/gcloud/storage/bucket.py#L527
dhermes commentedon Sep 18, 2014
Thanks, but note the
...blog/master/gcloud/...part of the link. That always points toHEADin master, rather than the explicit commit that was the tip ofmasterwhen you referenced it. That's why I recommended pressingyin the UI.tseaver commentedon Sep 18, 2014
I'm sorry not to know that part of the UI well -- I don't really like browsing code there, compared to using filesystem tools.
dhermes commentedon Sep 18, 2014
I suppose that's fine as well, just include a line number and the commit hash of
HEADat the time of posting.Merge pull request #193 from tseaver/139-save_default_object_acl-clea…
Merge pull request googleapis#139 from jgeewax/koss-collection-6
94 remaining items
chore(python): update dependencies in /.kokoro (#139)
chore: template updates (#139)
chore(python): rename default branch to main (#139)
tests: enable unit tests for Python 3.9 (#139)
chore(deps): update actions/setup-python action to v3 (#139)
refactor: Major refactoring of functions to improve readability, effi…
chore: add kokoro 3.9 config templates (#139)
Remove oauthlib modules from documentation, update user guide (#139)
feat: add configurable checksum support for uploads (#139)
chore: release 0.7.0 (#140)
spanner/dbapi: pass user_agent+python_version in ClientInfo
feat: support computed columns (#139)
chore: release 1.0.0 (#167)
chore(storage): fix lint error in _signing.py module (#140)
chore: release 1.2.0 (#139)