Skip to content

gcloud.storage.connection.Connection.api_request defaults path to None, but doesn't handle it #140

Closed

Description

@tseaver

https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/gcloud/storage/connection.py#L165

If the 'path' argument is not passed, the generated URI is nonsensical. We should either default to a sensible path ('/'), or else test for None and do something reasonable. As an alternative, we could just make 'path' a required argument (as it is for 'build_api_url').

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    api: storageIssues related to the Cloud Storage API.
    on Sep 22, 2014
  2. added this to the milestone on Sep 24, 2014
  3. tseaver commented on Sep 26, 2014

    @tseaver
    ContributorAuthor

    I've concluded that there is no sensible default value for 'path'. #194 makes is required.

  4. added a commit that references this issue on Sep 30, 2014
    3bd6bd8
  5. modified the milestones: , Storage Stable on Jan 30, 2015
  6. added a commit that references this issue on Jun 9, 2017
  7. added a commit that references this issue on Jan 17, 2020
  8. 87 remaining items

  9. added 10 commits that reference this issue on Nov 22, 2025
    b85c20a
    955cb6e
    ba41dae
    1b18fd5
    f4ff7d0
    4ba382b
    07bd3dd
    c92c40d
    6e9ea1c
    7aeb88b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: storageIssues related to the Cloud Storage API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions