Skip to content

gcloud.storage.bucket.Bucket.save_acl should clear existing ACL #138

Closed
Closed
gcloud.storage.bucket.Bucket.save_acl should clear existing ACL#138
Assignees
tseaver
Labels
🚨This issue needs some love.api: storageIssues related to the Cloud Storage API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Storage Stable

Description

@tseaver
tseaver
opened on Sep 18, 2014

If an ACL is passed to 'save_acl', it should clear (or overwrite) any existing 'acl' attribute on the bucket, in addition to patching it server-side.

Activity

  1. tseaver commented on Sep 18, 2014

    @tseaver
    tseaver
    on Sep 18, 2014
    ContributorAuthor

    Note that this issue also causes 'clear_acl' to leave the existing client-side 'acl' untouched.

  2. tseaver commented on Sep 18, 2014

    @tseaver
    tseaver
    on Sep 18, 2014
    ContributorAuthor

    'save_default_object_acl' also shows the same bug. (Tracked as #139)

  3. tseaver commented on Sep 18, 2014

    @tseaver
    tseaver
    on Sep 18, 2014
    ContributorAuthor

    https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/gcloud/storage/bucket.py#L453

  4. tseaver commented on Sep 19, 2014

    @tseaver
    tseaver
    on Sep 19, 2014
    ContributorAuthor

    Same bug in 'gcloud.storage.key.Key.save_acl':

    https://github.com/GoogleCloudPlatform/gcloud-python/blob/1f2aaf3606802f4f02eeb30e22e1082ef7f4594e/gcloud/storage/key.py#L410

  5. tseaver
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    api: storageIssues related to the Cloud Storage API.
    on Sep 22, 2014
  6. silvolu
    added this to the milestone on Sep 24, 2014
  7. tseaver
    closed this as completedin fb756b2on Sep 30, 2014
  8. silvolu
    added a commit that references this issue on Sep 30, 2014

    Merge pull request #192 from tseaver/138-save_acl-clear_existing_loca…

    23fc80f
  9. jgeewax
    modified the milestones: , Storage Stable on Jan 30, 2015
  10. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Apr 7, 2020

  11. 97 remaining items

  12. parthea
    added 9 commits that reference this issue on Nov 24, 2025

    chore: release 0.4.5 (#138)

    336496b

    chore: Add header checker config to python library synth (#138)

    26f0a6e

    feat: Comment/description support, bug fixes and better test coverage (…

    5d6f21a

    chore(python): group renovate prs (#138)

    a692cbe

    chore(deps): update dependency google-cloud-documentai to v2.16.1 (#138)

    40be61f

    refactor: Major refactoring of functions to improve readability, effi…

    b5ce391

    chore: update precommit hook pre-commit/pre-commit-hooks to v4 (#1083) (

    0c6c18b

    chore: release 2.1.0 (#138)

    f7a7d43

    _prepare_for_put was not being called at entity level (#138)

    0233134
  13. parthea
    added 5 commits that reference this issue on Mar 2, 2026

    chore(deps): update actions/setup-python action to v4 (#138)

    50b65ef

    chore(packaging): update dev status to stable (#142)

    d4d7800

    django: fix text lookups on numeric columns

    9325af1

    fix: Remove stray bigquery lines (#138)

    6158afd

    feat: find more items to cross reference (#138)

    98aa6db
  14. ohmayr
    added a commit that references this issue on Mar 31, 2026

    chore(deps): update actions/setup-python action to v4 (#138)

    a836ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: storageIssues related to the Cloud Storage API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions