Skip to content

fix(1-resman): consolidate overlapping tenant folder IAM bindings - #425

Closed
johnlakeee wants to merge 1 commit into
fix/1-resman-top-folder-roles-keyfrom
fix/1-resman-consolidate-tenant-folder-iam
Closed

johnlakeee wants to merge 1 commit into
fix/1-resman-top-folder-roles-keyfrom
fix/1-resman-consolidate-tenant-folder-iam

Conversation

@johnlakeee

Copy link
Copy Markdown
Collaborator

Description

In fast/stages-aw/1-resman/branch-tenants.tf, three separate modules/folder blocks (tenant-top-folders-iam, tenant-core-folders-iam, tenant-self-folders-iam) all managed authoritative google_folder_iam_binding resources on the same module.tenant-top-folders[each.key].id, causing duplicate role binding conflicts across overlapping roles.

  • Consolidate all tenant folder IAM bindings into module "tenant-top-folders-iam"
  • Merge core SA roles and top_folder_roles / core_folder_roles / tenant_folder_roles per unique role
  • Extend tests/test_resman_tenant_iam.py

Stacked on #424 (Part of #388, Milestone 1 — Group A, PR 4 of 6).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Performed

  • terraform fmt -check -recursive, terraform validate, tflint (155 directories, 0 failed)
  • ruff check & ruff format --check
  • pytest: 134 passed
  • All tests/test_*.sh shell suites passed

@github-actions github-actions Bot added Scope - Fast Related to Fabric FAST deployment stages in the fast directory Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent labels Nov 16, 2026
@Calvin-Cheng1

Copy link
Copy Markdown
Collaborator

@johnlakeee I believe this fix is already covered in #419

@aghassemlouei

Copy link
Copy Markdown
Member

Thanks for putting this together. #419 is now merged into main at commit a81c2772f5 and includes the tenant-top-folders-iam consolidation, declarative removed blocks with lifecycle { destroy = false }, and regression coverage in tests/test_bootstrap_resman_fixes.py, so #425 can be closed as superseded by #419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent Scope - Fast Related to Fabric FAST deployment stages in the fast directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants