Skip to content

fix(1-resman): fix top_folder_roles tenant_iam key lookup - #424

Closed
johnlakeee wants to merge 1 commit into
mainfrom
fix/1-resman-top-folder-roles-key
Closed

johnlakeee wants to merge 1 commit into
mainfrom
fix/1-resman-top-folder-roles-key

Conversation

@johnlakeee

Copy link
Copy Markdown
Collaborator

Description

In fast/stages-aw/1-resman/branch-tenants.tf, module "tenant-top-folders-iam" indexed local.tenant_iam with each.value.tenant.name (invalid attribute on string each.value.tenant) instead of each.key.

  • Fix key lookup to local.tenant_iam[each.key]
  • Add unit test tests/test_resman_tenant_iam.py

Part of #388 (Milestone 1 — Group A, PR 3 of 6).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Performed

  • terraform fmt -check -recursive, terraform validate, tflint (155 directories, 0 failed)
  • ruff check & ruff format --check
  • pytest: 133 passed
  • All tests/test_*.sh shell suites passed

@github-actions github-actions Bot added Scope - Fast Related to Fabric FAST deployment stages in the fast directory Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent labels Nov 16, 2026
@Calvin-Cheng1

Copy link
Copy Markdown
Collaborator

@johnlakeee I believe this fix is already covered under #419

@aghassemlouei

Copy link
Copy Markdown
Member

Thanks for putting this together. #419 is now merged into main at commit a81c2772f5 and includes the local.tenant_iam[k] lookup fix in fast/stages-aw/1-resman/branch-tenants.tf along with regression coverage in tests/test_bootstrap_resman_fixes.py, so #424 can be closed as superseded by #419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent Scope - Fast Related to Fabric FAST deployment stages in the fast directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants