Repository navigation
test(cli): update Stage 0 tests for allowed_vpc_peering_producers and add Release Please footer rule - #389
Merged
Conversation
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray and
mgcarey-google
October 31, 2026 01:10
… add Release Please footer rule
aghassemlouei
force-pushed
the
fix/cli-tests-vpc-peering-producers
branch
from
October 31, 2026 01:19
fe88c17 to
e1af4dc
Compare
aghassemlouei
marked this pull request as ready for review
October 31, 2026 01:19
aghassemlouei
enabled auto-merge (squash)
October 31, 2026 01:23
17 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Stage 0 CLI render tests, snapshots, and custom organization policy
templatefilesynchronization test to includeallowed_vpc_peering_producersintroduced in #352, and add a Markdown horizontal rule above theBeep Boopfooter in.github/release-please-config.json.cli/tests/test_repo.py, addallowed_vpc_peering_producers = []to_TEMPLATE_VARSsotemplatefileevaluation offast/stages-aw/0-bootstrap/data/custom-org-policies/networking_policy.yamlsucceeds duringtest_templated_keys_match_templatefileacrossFEDRAMP_MODERATEandIL5.cli/tests/test_render_stages.pyandcli/tests/__snapshots__/test_render_stages.ambr, include"allowed_vpc_peering_producers": ["under:folders/832634261155"]in the expected Stage 0org_policies_config.constraintsdictionary and snapshot fixtures to matchfast/stages-aw/0-bootstrap/terraform.tfvars.sample..github/release-please-config.jsonandtests/test_label_taxonomy.py, prefix"pull-request-footer"with---\nso Release Please PR bodies render a horizontal rule directly above theBeep Boopfooter sentence without adding a top horizontal rule or altering tagged GitHub Release bodies.Without these test updates, the
Stellar CLI Tests & Code Qualityjob in.github/workflows/ci.ymlfails onmainacross 10 Stage 0 test cases, which also causes GitHub Code Scanning to mark the.github/workflows/ci.ymlTrivy tool configuration as failing onmain.Type of Change
Deployment & Compliance Impact
constraints/compute.restrictVpcPeeringand Release Please PR footer formatting)Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
Ran the repository and Stellar CLI test suites and static analysis checks locally:
python3 -m unittest tests/test_label_taxonomy.py cd cli uv run --locked ruff check uv run --locked ruff format --check uv run --locked pyright uv run --locked pytestAll 5
test_label_taxonomy.pychecks and all 875 CLI tests (833unit tests and42@pytest.mark.terraformtests),ruff, andpyrightchecks passed with zero errors.