Skip to content

test(cli): update Stage 0 tests for allowed_vpc_peering_producers and add Release Please footer rule - #389

Merged
aghassemlouei merged 1 commit into
mainfrom
fix/cli-tests-vpc-peering-producers
Oct 31, 2026
Merged

aghassemlouei merged 1 commit into
mainfrom
fix/cli-tests-vpc-peering-producers

Conversation

@aghassemlouei

@aghassemlouei aghassemlouei commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Description

Update the Stage 0 CLI render tests, snapshots, and custom organization policy templatefile synchronization test to include allowed_vpc_peering_producers introduced in #352, and add a Markdown horizontal rule above the Beep Boop footer in .github/release-please-config.json.

  • In cli/tests/test_repo.py, add allowed_vpc_peering_producers = [] to _TEMPLATE_VARS so templatefile evaluation of fast/stages-aw/0-bootstrap/data/custom-org-policies/networking_policy.yaml succeeds during test_templated_keys_match_templatefile across FEDRAMP_MODERATE and IL5.
  • In cli/tests/test_render_stages.py and cli/tests/__snapshots__/test_render_stages.ambr, include "allowed_vpc_peering_producers": ["under:folders/832634261155"] in the expected Stage 0 org_policies_config.constraints dictionary and snapshot fixtures to match fast/stages-aw/0-bootstrap/terraform.tfvars.sample.
  • In .github/release-please-config.json and tests/test_label_taxonomy.py, prefix "pull-request-footer" with ---\n so Release Please PR bodies render a horizontal rule directly above the Beep Boop footer sentence without adding a top horizontal rule or altering tagged GitHub Release bodies.

Without these test updates, the Stellar CLI Tests & Code Quality job in .github/workflows/ci.yml fails on main across 10 Stage 0 test cases, which also causes GitHub Code Scanning to mark the .github/workflows/ci.yml Trivy tool configuration as failing on main.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: N/A (CLI test suite alignment for constraints/compute.restrictVpcPeering and Release Please PR footer formatting)

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/stages-aw/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in docs/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL4, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

Ran the repository and Stellar CLI test suites and static analysis checks locally:

python3 -m unittest tests/test_label_taxonomy.py
cd cli
uv run --locked ruff check
uv run --locked ruff format --check
uv run --locked pyright
uv run --locked pytest

All 5 test_label_taxonomy.py checks and all 875 CLI tests (833 unit tests and 42 @pytest.mark.terraform tests), ruff, and pyright checks passed with zero errors.

@aghassemlouei aghassemlouei added Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent labels Oct 31, 2026
@github-actions github-actions Bot added the Scope - Fast Related to Fabric FAST deployment stages in the fast directory label Oct 31, 2026
@aghassemlouei
aghassemlouei force-pushed the fix/cli-tests-vpc-peering-producers branch from fe88c17 to e1af4dc Compare October 31, 2026 01:19
@aghassemlouei aghassemlouei changed the title test(cli): update Stage 0 render and templatefile tests for allowed_vpc_peering_producers test(cli): update Stage 0 tests for allowed_vpc_peering_producers and add Release Please footer rule Oct 31, 2026
@aghassemlouei
aghassemlouei marked this pull request as ready for review October 31, 2026 01:19
@aghassemlouei
aghassemlouei enabled auto-merge (squash) October 31, 2026 01:23
@aghassemlouei
aghassemlouei merged commit 90bdb1e into main Oct 31, 2026
23 checks passed
@aghassemlouei
aghassemlouei deleted the fix/cli-tests-vpc-peering-producers branch October 31, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent Scope - Fast Related to Fabric FAST deployment stages in the fast directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant