Repository navigation
fix(gitlab): store gitlab.rb and TLS key in Secret Manager and validate hostname - #295
Merged
pulsingSignal merged 1 commit intoNov 6, 2026
Conversation
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray and
mgcarey-google
October 20, 2026 02:31
aghassemlouei
force-pushed
the
fix/gitlab-secret-manager-and-hostname-validation
branch
2 times, most recently
from
October 20, 2026 22:33
6cb79e5 to
832db99
Compare
aghassemlouei
force-pushed
the
fix/gitlab-secret-manager-and-hostname-validation
branch
12 times, most recently
from
October 23, 2026 12:46
099dfca to
c8eae5d
Compare
aghassemlouei
force-pushed
the
fix/gitlab-secret-manager-and-hostname-validation
branch
3 times, most recently
from
October 28, 2026 17:44
52a802d to
1be5869
Compare
Collaborator
|
@aghassemlouei Could you please rebase this branch onto |
aghassemlouei
force-pushed
the
fix/gitlab-secret-manager-and-hostname-validation
branch
from
November 6, 2026 14:48
b127bc3 to
4de665b
Compare
Member
Author
Done and done! |
Collaborator
|
LGTM! |
pulsingSignal
enabled auto-merge (squash)
November 6, 2026 15:18
pulsingSignal
approved these changes
Nov 6, 2026
pulsingSignal
deleted the
fix/gitlab-secret-manager-and-hostname-validation
branch
November 6, 2026 15:21
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
google_secret_manager_secret.gitlab_rbandgoogle_secret_manager_secret.gitlab_ssl_keywith secret versions androles/secretmanager.secretAccessorIAM bindings inblueprints/third-party-solutions/gitlab/gitlab.tf, and fetchgitlab.rband the TLS private key viagcloud secrets versions access latestinblueprints/third-party-solutions/gitlab/assets/cloud-config.yamlrather than storing sensitive values in cleartext GCE instance metadata.secretmanager.googleapis.cominblueprints/third-party-solutions/gitlab/main.tf, wiregitlab_rails['redis_password']togoogle_redis_instance.cache.auth_stringinblueprints/third-party-solutions/gitlab/assets/config.rb.tpl, guard/tmp/gitlab/sshd_configand/tmp/gitlab/ssl/${gitlab_cert_name}.crtpreparation with[ ! -f ... ] ||and quote"${gitlab_config.hostname}"inblueprints/third-party-solutions/gitlab/assets/cloud-config.yaml, validategitlab_config.hostnameas an RFC 1123 hostname inblueprints/third-party-solutions/gitlab/variables.tf, and markoutput "instance"assensitive = trueinblueprints/third-party-solutions/gitlab/outputs.tf(updatingREADME.md) so root-module plans succeed whenvar.gitlab_configis interpolated intomodule.gitlab-instance.Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
bash tools/run_tests.sh,bash tools/lint.sh, anduv run --project . --locked python tools/check_documentation.py blueprints/third-party-solutions/gitlab.terraform initandterraform planinblueprints/third-party-solutions/gitlab.