[tamirdresher]

Summary

Three fixes for the watch --execute subsystem, addressing Windows compatibility, API rate limiting, and code duplication.

Closes #920, #923

---

What changed and why

Fix 1: Windows shell: true for all execFile calls (#920)

Problem: On Windows, Node.js execFile() cannot resolve bare command names through PATH or execute .cmd/.bat files without shell: true. Every capability that spawns gh, copilot, git, or other commands fails with spawn EINVAL.

Fix: Added shell: process.platform === 'win32' to all 37+ execFile callsites across:

• capabilities/board.ts (7 calls)
• capabilities/self-pull.ts (9 calls)
• capabilities/execute.ts
• capabilities/fleet-dispatch.ts
• capabilities/wave-dispatch.ts
• capabilities/two-pass.ts
• core/gh-cli.ts (6 calls)
• watch/health.ts
• watch/index.ts

A shared IS_WINDOWS constant (process.platform === 'win32') is exported from the new agent-spawn.ts module.

Fix 2: Shared agent spawn module (DRY)

Problem: buildAgentCommand() was copy-pasted 7 times across capabilities (execute, fleet-dispatch, wave-dispatch, decision-hygiene, monitor-teams, monitor-email, retro). Each copy had slight variations and none included the Windows shell fix.

Fix: Created watch/agent-spawn.ts with:

• buildAgentCommand(prompt, context) — builds cmd + args from agentCmd config or defaults to standalone copilot CLI
• spawnWithTimeout(cmd, args, cwd, timeoutMs) — execFile with timeout + Windows shell support
• spawnAgent(cmd, args, cwd, timeoutMs) — same but resolves with {success, error} instead of rejecting
• IS_WINDOWS constant

All 7 capabilities now import from this single module. ~150 lines of duplication removed.

Default change: The default agent command changed from gh copilot (deprecated) to standalone copilot CLI. The agentCmd config option overrides this.

Fix 3: Shared round-level issue fetch (#923)

Problem: Each capability independently called gh issue list and gh pr list, resulting in 6+ GitHub API calls per capability per round. With 7 capabilities enabled, that is 40+ API calls per round per repo. Running 4 repos simultaneously hits GitHub's 5000/hr rate limit within minutes.

Fix: Added RoundData interface to types.ts:

interface RoundData {
  issues: WatchWorkItem[];
  pullRequests: PullRequest[];
  fetchedAt: number;
}

The main round runner in index.ts fetches issues and PRs once per round and passes them via context.roundData. Capabilities that need issue/PR data read from the shared context instead of making their own API calls. This reduces API calls from ~40 to ~2 per round per repo.

---

Files changed (16 files, +245 -222)

File	Change
watch/agent-spawn.ts	NEW — shared spawn utilities
watch/types.ts	Added RoundData interface
watch/index.ts	Fetch once per round, populate roundData
watch/health.ts	shell: IS_WINDOWS
capabilities/board.ts	shell: IS_WINDOWS on 7 execFile calls
capabilities/self-pull.ts	shell: IS_WINDOWS on 9 execFile calls
capabilities/execute.ts	Uses shared spawnAgent() + roundData
capabilities/fleet-dispatch.ts	Removed .cmd hack, shared spawn + roundData
capabilities/wave-dispatch.ts	Uses shared spawnAgent() + roundData
capabilities/two-pass.ts	shell: IS_WINDOWS + roundData
capabilities/decision-hygiene.ts	Removed local copies, imports from agent-spawn
capabilities/monitor-teams.ts	Removed local copies, imports from agent-spawn
capabilities/monitor-email.ts	Removed local copies, imports from agent-spawn
capabilities/retro.ts	Removed local copies, imports from agent-spawn
core/gh-cli.ts	shell: IS_WINDOWS on all 6 execFile calls
test/cli/watch-execute.test.ts	Updated expectations for copilot default

Testing

• Unit tests: All 16 watch-execute tests pass (updated for new copilot default)
• TypeScript build: Clean compile with TypeScript 5.9.3
• E2E (manual): Ran local build across 4 repos on Windows:
  • ✅ No spawn EINVAL errors
  • ✅ No rate limit errors with shared fetch
  • ✅ Triage auto-routes issues
  • ✅ Execute spawns agency sessions for eligible issues
  • Pre-existing Windows test failures in storage-provider.test.ts (unicode paths), template-sync.test.ts (template content), team-root-resolution.test.ts (path resolution) — all unrelated to this PR