Skip to content

fix(sdk): Add shell: IS_WINDOWS to ADO adapter execFileSync calls #941

Closed

Description

@tamirdresher

Summary

azure-devops.ts in squad-sdk uses execFileSync('az', ...) without shell: true on Windows. On Windows, az is typically a .cmd wrapper, so execFileSync without shell: true will fail to resolve it.

Context

Found during Q's review of PR #927 (watch subsystem Windows fixes). This is a pre-existing bug, not a regression from that PR.

The same pattern was already fixed in the watch subsystem's agent-spawn.ts via the IS_WINDOWS constant and shell: IS_WINDOWS option.

Expected Fix

Add shell: IS_WINDOWS (where IS_WINDOWS = process.platform === 'win32') to all execFileSync / execFile calls in packages/squad-sdk/src/platform/azure-devops.ts that invoke az CLI.

Files Affected

  • packages/squad-sdk/src/platform/azure-devops.ts

Activity

  1. added a commit that references this issue on Apr 9, 2026
    29bded6
  2. tamirdresher commented on Apr 12, 2026

    @tamirdresher
    CollaboratorAuthor

    Confirmed: PR #927 (on insider) fixes the same class of bug (\shell:true\ on Windows) but only for the watch capabilities (\�xecFile\ in cli/commands/watch/).

    This issue is about the ADO adapter (\�xecFileSync('az', ...)\ in \packages/squad-sdk/src/platform/azure-devops.ts), which is a separate code path and still unfixed. PR #927 doesn't touch it.

    Still needs a dedicated fix — same pattern: add \shell: process.platform === 'win32'\ to the ADO adapter's \�xecFileSync\ calls.

  3. added a commit that references this issue on Apr 12, 2026
    e49d9c9
  4. added a commit that references this issue on Apr 21, 2026
    5c94fdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions