Skip to content

fix(gh-aw): bridge automatic bootstrap into triage - #2044

Merged
bradygaster merged 1 commit into
devfrom
bradygaster-fix-bootstrap-triage-continuity
Sep 14, 2026
Merged

bradygaster merged 1 commit into
devfrom
bradygaster-fix-bootstrap-triage-continuity

Conversation

@bradygaster

Copy link
Copy Markdown
Collaborator

What

Make the automatic bootstrap issue immediately usable by /squad triage after its linked Cast PR merges. The bootstrap materializer now derives and upserts one canonical structured squad_artifact=research comment from the validated proposal payload, repairs duplicate artifacts idempotently, preserves newer focused research, and recognizes squad/bootstrap-cast during Team Guard Cast discovery.

Why

Follow-up to #2041 and #2043. Real target-repository runs showed that the bootstrap issue contained validated proposals only in its body, while normal triage requires a structured research artifact. Team Guard also searched only manual squad/cast-* branches and missed the deterministic bootstrap branch.

How

  • Extend the authenticated bootstrap validator with strict bootstrap research creation/discovery helpers and exact durable-marker validation.
  • Include research-artifact presence in bootstrap recovery state so existing installations backfill the missing seed without duplicating the Cast PR or issue.
  • Upsert the canonical seed in the typed materializer; preserve a later focused research artifact and delete older duplicates.
  • Make Cast discovery accept the exact squad/bootstrap-cast branch plus existing manual Cast branches, while failing closed on multiple candidates.
  • Update bootstrap issue guidance and the gh-aw guide to describe merge → triage, with focused research as an optional deeper pass.

External test-repo refresh

Do not manually edit octodemo/zava-social-backend-bradyg-003. After this PR merges to dev:

  1. Refresh/reinstall bradygaster/squad/workflows/squad.md@dev and bradygaster/squad/workflows/squad-bootstrap.md@dev in the target repo, then strict-compile both generated workflows.
  2. Push the refreshed source/lock files to the target repo default branch so squad-bootstrap runs.
  3. Confirm bootstrap recovery reuses PR feat: GitHub Issues intake, PRD mode, and human team members #2 and issue [TEST] API capability test — will be deleted #3, creates exactly one bot-authored squad_artifact=research comment on issue [TEST] API capability test — will be deleted #3, and creates no duplicate Cast PR or proposals issue.
  4. Before PR feat: GitHub Issues intake, PRD mode, and human team members #2 is merged, rerun /squad triage on issue [TEST] API capability test — will be deleted #3 and confirm it pauses with the exact PR feat: GitHub Issues intake, PRD mode, and human team members #2 URL.
  5. Merge PR feat: GitHub Issues intake, PRD mode, and human team members #2, rerun /squad triage, and confirm it consumes the bootstrap research seed and posts a triage artifact instead of requesting /squad research.
  6. Run a focused /squad research Focus only on proposal P1: ..., confirm it replaces the seed rather than adding a duplicate, then rerun triage successfully.

⚠️ Quick Check

  • Changeset included for the distributed workflow behavior change

PR Readiness Checklist

Branch & Commit

  • Branch created from dev
  • Branch was current with dev at start
  • Verified seven intended files and no deletions
  • PR is not draft
  • Single coherent commit

Build & Test

  • npm run build passes
  • Full npm test is not green in this worktree: 9,063 tests pass; 11 unrelated existing failures remain in worktree/external-state tests, template version-stamp mutation, observer timing, and a gh-aw v0.89.2 protected-files expectation. The five affected suites pass: 752/752.
  • npm run lint passes after build
  • npm run lint:eslint passes with existing warnings only
  • npm run lint:docs passes
  • All seven workflows strict-compiled twice with byte-identical emitted locks; emitted expression scan passed
  • actionlint comparison against origin/dev is unchanged: one existing gh-aw-generated if-cond diagnostic in both baseline and head

Changeset

  • .changeset/fix-bootstrap-triage-continuity.md added

Docs

  • Updated the gh-aw bootstrap journey guidance

Exports

  • N/A — no SDK exports changed

Breaking Changes

None.

Waivers

None.

Follow-up to #2041 and #2043

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 14, 2026 22:03
@github-actions

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #2044

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 7
Files added 1
Files modified 6
Files deleted 0
Modules touched 3

🎯 Risk Factors

  • 7 files changed (6-20 → MEDIUM)
  • 3 modules touched (2-4 → MEDIUM)

📦 Modules Affected

docs (1 file)
  • docs/src/content/docs/guide/gh-aw.md
root (4 files)
  • .changeset/fix-bootstrap-triage-continuity.md
  • workflows/shared/squad-bootstrap-validator.mjs
  • workflows/squad-bootstrap.md
  • workflows/squad.md
tests (2 files)
  • test/gh-aw-bootstrap-workflow.test.ts
  • test/gh-aw-quality.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 2e37a82

PR Scope: 🔧 Infrastructure

⚠️ 1 item(s) to address before review

Status Check Details
✅ Single commit 1 commit — clean history
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present Changeset file found
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
✅ CI passing All checks passing

Files Changed (7 files, +430 −24)

File +/−
.changeset/fix-bootstrap-triage-continuity.md +8 −0
docs/src/content/docs/guide/gh-aw.md +6 −3
test/gh-aw-bootstrap-workflow.test.ts +117 −3
test/gh-aw-quality.test.ts +27 −3
workflows/shared/squad-bootstrap-validator.mjs +174 −9
workflows/squad-bootstrap.md +90 −5
workflows/squad.md +8 −1

Total: +430 −24


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Four moderate correctness issues remain in bootstrap artifact handling, plus documentation and regression-coverage nits.

Review tier: Lite
Findings: None

What changed in this PR

This PR connects automatic bootstrap output to /squad triage through canonical research artifacts and deterministic Cast discovery.

Changes:

  • Adds research artifact validation, recovery, deduplication, and preservation.
  • Recognizes the squad/bootstrap-cast branch.
  • Updates tests, guidance, documentation, and the changeset.
File Summary Findings
workflows/​squad.md Adds bootstrap Cast branch discovery. None.
workflows/​squad-bootstrap.md Materializes and repairs research artifacts. Moderate (1 vote): Preserve the existing issue body during research-only recovery.
Nit (1 vote): Add coverage for preserving newer focused research.
workflows/​shared/​squad-bootstrap-validator.mjs Validates and discovers bootstrap research data. Moderate (1 vote): Match normal research fence semantics.
Moderate (1 vote): Classify seeds by durable provenance, not title.
Moderate (1 vote): Reject malformed structured-data envelopes.
test/​gh-aw-quality.test.ts Tests Cast branch filtering. None.
test/​gh-aw-bootstrap-workflow.test.ts Tests bootstrap research behavior. None.
docs/​src/​content/​docs/​guide/​gh-aw.md Documents the updated bootstrap journey. Nit (1 vote): Include /squad plan before /squad activate.
.changeset/​fix-bootstrap-triage-continuity.md Records the workflow change. None.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bradygaster
bradygaster merged commit 92c3cb6 into dev Sep 14, 2026
19 checks passed
@bradygaster
bradygaster deleted the bradygaster-fix-bootstrap-triage-continuity branch September 14, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants