Repository navigation
fix(gh-aw): bridge automatic bootstrap into triage - #2044
Conversation
🟡 Impact Analysis — PR #2044Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affecteddocs (1 file)
root (4 files)
tests (2 files)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (7 files, +430 −24)
| File | +/− |
|---|---|
.changeset/fix-bootstrap-triage-continuity.md |
+8 −0 |
docs/src/content/docs/guide/gh-aw.md |
+6 −3 |
test/gh-aw-bootstrap-workflow.test.ts |
+117 −3 |
test/gh-aw-quality.test.ts |
+27 −3 |
workflows/shared/squad-bootstrap-validator.mjs |
+174 −9 |
workflows/squad-bootstrap.md |
+90 −5 |
workflows/squad.md |
+8 −1 |
Total: +430 −24
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Four moderate correctness issues remain in bootstrap artifact handling, plus documentation and regression-coverage nits.
Review tier: Lite
Findings: None
What changed in this PR
This PR connects automatic bootstrap output to /squad triage through canonical research artifacts and deterministic Cast discovery.
Changes:
- Adds research artifact validation, recovery, deduplication, and preservation.
- Recognizes the
squad/bootstrap-castbranch. - Updates tests, guidance, documentation, and the changeset.
| File | Summary | Findings |
|---|---|---|
workflows/squad.md |
Adds bootstrap Cast branch discovery. | None. |
workflows/squad-bootstrap.md |
Materializes and repairs research artifacts. | Moderate (1 vote): Preserve the existing issue body during research-only recovery. Nit (1 vote): Add coverage for preserving newer focused research. |
workflows/shared/squad-bootstrap-validator.mjs |
Validates and discovers bootstrap research data. | Moderate (1 vote): Match normal research fence semantics. Moderate (1 vote): Classify seeds by durable provenance, not title. Moderate (1 vote): Reject malformed structured-data envelopes. |
test/gh-aw-quality.test.ts |
Tests Cast branch filtering. | None. |
test/gh-aw-bootstrap-workflow.test.ts |
Tests bootstrap research behavior. | None. |
docs/src/content/docs/guide/gh-aw.md |
Documents the updated bootstrap journey. | Nit (1 vote): Include /squad plan before /squad activate. |
.changeset/fix-bootstrap-triage-continuity.md |
Records the workflow change. | None. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
What
Make the automatic bootstrap issue immediately usable by
/squad triageafter its linked Cast PR merges. The bootstrap materializer now derives and upserts one canonical structuredsquad_artifact=researchcomment from the validated proposal payload, repairs duplicate artifacts idempotently, preserves newer focused research, and recognizessquad/bootstrap-castduring Team Guard Cast discovery.Why
Follow-up to #2041 and #2043. Real target-repository runs showed that the bootstrap issue contained validated proposals only in its body, while normal triage requires a structured research artifact. Team Guard also searched only manual
squad/cast-*branches and missed the deterministic bootstrap branch.How
squad/bootstrap-castbranch plus existing manual Cast branches, while failing closed on multiple candidates.External test-repo refresh
Do not manually edit
octodemo/zava-social-backend-bradyg-003. After this PR merges todev:bradygaster/squad/workflows/squad.md@devandbradygaster/squad/workflows/squad-bootstrap.md@devin the target repo, then strict-compile both generated workflows.squad-bootstrapruns.squad_artifact=researchcomment on issue [TEST] API capability test — will be deleted #3, and creates no duplicate Cast PR or proposals issue./squad triageon issue [TEST] API capability test — will be deleted #3 and confirm it pauses with the exact PR feat: GitHub Issues intake, PRD mode, and human team members #2 URL./squad triage, and confirm it consumes the bootstrap research seed and posts a triage artifact instead of requesting/squad research./squad research Focus only on proposal P1: ..., confirm it replaces the seed rather than adding a duplicate, then rerun triage successfully.PR Readiness Checklist
Branch & Commit
devdevat startBuild & Test
npm run buildpassesnpm testis not green in this worktree: 9,063 tests pass; 11 unrelated existing failures remain in worktree/external-state tests, template version-stamp mutation, observer timing, and a gh-aw v0.89.2 protected-files expectation. The five affected suites pass: 752/752.npm run lintpasses after buildnpm run lint:eslintpasses with existing warnings onlynpm run lint:docspassesorigin/devis unchanged: one existing gh-aw-generatedif-conddiagnostic in both baseline and headChangeset
.changeset/fix-bootstrap-triage-continuity.mdaddedDocs
Exports
Breaking Changes
None.
Waivers
None.