Repository navigation
fix(gh-aw): chunk bootstrap payload transport - #2043
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🟡 Impact Analysis — PR #2043Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affecteddocs (1 file)
root (3 files)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 4 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ❌ | Branch up to date | dev is 1 commit(s) ahead — rebase recommended |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | All 1 Copilot thread(s) resolved |
| ✅ | CI passing | All checks passing |
Files Changed (5 files, +378 −10)
| File | +/− |
|---|---|
.changeset/fix-bootstrap-payload-transport.md |
+7 −0 |
docs/src/content/docs/guide/gh-aw.md |
+9 −0 |
test/gh-aw-bootstrap-workflow.test.ts |
+152 −0 |
workflows/shared/squad-bootstrap-validator.mjs |
+149 −1 |
workflows/squad-bootstrap.md |
+61 −9 |
Total: +378 −10
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Three unresolved findings remain, including one critical integrity-pin test gap.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open findings (1)
What changed in this PR
This PR replaces the oversized bootstrap payload with bounded, integrity-checked Base64 chunks.
Changes:
- Adds deterministic chunk encoding and reconstruction.
- Updates workflow safe outputs and validation.
- Adds regression coverage and a CLI/SDK changeset.
| File | Summary and final review comment |
|---|---|
workflows/squad-bootstrap.md |
Defines chunked transport and materialization. Critical (1 vote): add a test verifying the validator’s SHA-256 integrity pin. |
workflows/shared/squad-bootstrap-validator.mjs |
Implements encoding and validation. Moderate (1 vote): add multibyte and boundary-spanning UTF-8 coverage. |
test/gh-aw-bootstrap-workflow.test.ts |
Adds transport and corruption coverage. Moderate (1 vote): parse the emitted schema and verify chunk, metadata, and legacy-input contracts. |
.changeset/fix-bootstrap-payload-transport.md |
Records the required package patch releases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Follow-up to github#2041 and github#2043 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Summary
Refs #2009.
Transport contract
payload_chunk_00throughpayload_chunk_15)NN:<canonical-base64>The model still produces one validated payload containing both Cast and research content. Chunking occurs only after semantic validation, so the two outputs cannot drift.
Validation
npm run build: passed84fabe365527e7f99da13b76407fed6023829c477d94be88839ca4fecc4d0471payload; serialized config is 2,277 bytesDesign note
repo-memorywas evaluated and rejected for this same-run transport because it adds a persistent branch mutation, artifact download choreography, stale-memory exposure, cleanup requirements, and race/idempotency complexity. Fixed safe-output chunks are the smallest bounded change and are validated directly by gh-aw's per-string guard.