Repository navigation
chore: clean up deferred M1 review nits - #1875
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to documentation and test helpers, and the updated skillBlock() behavior is covered by focused boundary tests with no remaining correctness concerns found.
Pull request overview
This PR closes out the five deferred “M1 review nits” tracked in #1781 by tightening documentation wording, removing a dead test helper, and correcting skillBlock() extraction semantics with focused boundary tests.
Changes:
- Tighten
gh-awguide prose to name the exact staged paths and the specific audit-log directory (.github/aw/logs/). - Update PAO history to reference the committed decision entry in
.squad/decisions.md(instead of an uncommitted inbox path). - Remove the unused
runGate()helper and updateskillBlock()to preserve exact skill boundaries, including new adjacent-boundary test coverage.
File summaries
| File | Description |
|---|---|
test/gh-aw-quality.test.ts |
Removes the unused runGate() helper (no behavior change to the existing inline gate invocations). |
test/gh-aw-plan-lifecycle.test.ts |
Fixes skillBlock() extraction to include the heading and stop at the next skill/end marker/EOF; adds focused tests for adjacent boundaries and fail-closed cases. |
docs/src/content/docs/guide/gh-aw.md |
Tightens staging guidance and restores the explicit audit-log directory path (.github/aw/logs/). |
.squad/agents/pao/history.md |
Replaces the missing inbox pointer with a reference to the merged decision entry in .squad/decisions.md. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closes #1781 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
243a6b5 to
63a1416
Compare
|
🟡 Impact Analysis — PR #1875Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affecteddocs (1 file)
squad-state (1 file)
tests (2 files)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 9 check(s) failing: test, test, sdk-exports-validation, docs-quality, samples-build, Policy Gates, Shebang EOL, changes, Changeset Drift |
Files Changed (4 files, +58 −36)
| File | +/− |
|---|---|
.squad/agents/pao/history.md |
+1 −1 |
docs/src/content/docs/guide/gh-aw.md |
+3 −6 |
test/gh-aw-plan-lifecycle.test.ts |
+54 −9 |
test/gh-aw-quality.test.ts |
+0 −20 |
Total: +58 −36
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized, align with the documented nits in #1781, and the updated skillBlock() behavior is covered by new focused tests.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
Summary
skillBlock()preserve exact skill boundariesFive-nit disposition
.gitattributes,.github/workflows/, and.github/skills/..github/aw/logs/..squad/decisions.md.runGate()helper is removed; inline calls are unchanged.skillBlock()includes the requested heading, excludes the next skill/end marker, handles EOF, and fails closed on missing or duplicate markers. Focused adjacent-boundary coverage was added.Validation
start + 1mutation fails the new heading-boundary assertion; restored implementation passes the same assertiongit diff --checkpassedvitest@4.1.11; manifests and lockfile were not changedThis PR is stacked on #1873 so its diff contains only #1781.
Closes #1781