Skip to content

chore: clean up deferred M1 review nits - #1875

Merged
bradygaster merged 1 commit into
devfrom
bradygaster-1781-deferred-review-cleanup
Aug 25, 2026
Merged

bradygaster merged 1 commit into
devfrom
bradygaster-1781-deferred-review-cleanup

Conversation

@bradygaster

Copy link
Copy Markdown
Collaborator

Summary

  • tighten the gh-aw staging and audit-log guidance
  • replace PAO history's missing inbox pointer with the committed decision record
  • remove the unused quality-test helper and make skillBlock() preserve exact skill boundaries

Five-nit disposition

  1. The staging prose now names only .gitattributes, .github/workflows/, and .github/skills/.
  2. The audit-log guidance now names .github/aw/logs/.
  3. PAO history now points to the matching committed entry in .squad/decisions.md.
  4. The zero-caller runGate() helper is removed; inline calls are unchanged.
  5. skillBlock() includes the requested heading, excludes the next skill/end marker, handles EOF, and fails closed on missing or duplicate markers. Focused adjacent-boundary coverage was added.

Validation

  • old start + 1 mutation fails the new heading-boundary assertion; restored implementation passes the same assertion
  • Node TypeScript syntax checks passed for both changed test files
  • markdownlint and cspell passed for the changed guide
  • git diff --check passed
  • focused Vitest and project ESLint were attempted after configuring the required package-feed proxy, but the proxy does not contain lockfile-pinned vitest@4.1.11; manifests and lockfile were not changed

This PR is stacked on #1873 so its diff contains only #1781.

Closes #1781

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are narrowly scoped to documentation and test helpers, and the updated skillBlock() behavior is covered by focused boundary tests with no remaining correctness concerns found.

Pull request overview

This PR closes out the five deferred “M1 review nits” tracked in #1781 by tightening documentation wording, removing a dead test helper, and correcting skillBlock() extraction semantics with focused boundary tests.

Changes:

  • Tighten gh-aw guide prose to name the exact staged paths and the specific audit-log directory (.github/aw/logs/).
  • Update PAO history to reference the committed decision entry in .squad/decisions.md (instead of an uncommitted inbox path).
  • Remove the unused runGate() helper and update skillBlock() to preserve exact skill boundaries, including new adjacent-boundary test coverage.
File summaries
File Description
test/gh-aw-quality.test.ts Removes the unused runGate() helper (no behavior change to the existing inline gate invocations).
test/gh-aw-plan-lifecycle.test.ts Fixes skillBlock() extraction to include the heading and stop at the next skill/end marker/EOF; adds focused tests for adjacent boundaries and fail-closed cases.
docs/src/content/docs/guide/gh-aw.md Tightens staging guidance and restores the explicit audit-log directory path (.github/aw/logs/).
.squad/agents/pao/history.md Replaces the missing inbox pointer with a reference to the merged decision entry in .squad/decisions.md.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Closes #1781

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster force-pushed the bradygaster-1781-deferred-review-cleanup branch from 243a6b5 to 63a1416 Compare August 25, 2026 14:59
@bradygaster
bradygaster changed the base branch from bradygaster-1780-ontology-drift-guard to dev August 25, 2026 14:59
@bradygaster
bradygaster requested a lite review from Copilot August 25, 2026 14:59
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Squad File Leakage Detected

The following .squad/ files were modified in this PR:

  • .squad/agents/pao/history.md

These files affect team routing, agent charters, and decisions.
If intentional, ensure approval from the team lead.

@github-actions

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #1875

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 4
Files added 0
Files modified 4
Files deleted 0
Modules touched 3

🎯 Risk Factors

  • 4 files changed (≤5 → LOW)
  • 3 modules touched (2-4 → MEDIUM)

📦 Modules Affected

docs (1 file)
  • docs/src/content/docs/guide/gh-aw.md
squad-state (1 file)
  • .squad/agents/pao/history.md
tests (2 files)
  • test/gh-aw-plan-lifecycle.test.ts
  • test/gh-aw-quality.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 63a1416

PR Scope: 🔧 Infrastructure

⚠️ 2 item(s) to address before review

Status Check Details
✅ Single commit 1 commit — clean history
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present No source files changed — changeset not required
✅ Scope clean ⚠️ PR includes 1 .squad/ file(s) — ensure these are intentional
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
❌ CI passing 9 check(s) failing: test, test, sdk-exports-validation, docs-quality, samples-build, Policy Gates, Shebang EOL, changes, Changeset Drift

Files Changed (4 files, +58 −36)

File +/−
.squad/agents/pao/history.md +1 −1
docs/src/content/docs/guide/gh-aw.md +3 −6
test/gh-aw-plan-lifecycle.test.ts +54 −9
test/gh-aw-quality.test.ts +0 −20

Total: +58 −36


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are localized, align with the documented nits in #1781, and the updated skillBlock() behavior is covered by new focused tests.

Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@bradygaster
bradygaster merged commit 08b89da into dev Aug 25, 2026
16 of 27 checks passed
@bradygaster
bradygaster deleted the bradygaster-1781-deferred-review-cleanup branch September 9, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post-merge cleanup: five deferred Copilot review nits from M1 PRs

2 participants