You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(sdk): Encode channelId in Teams deep-link URL #771
PR #768 added validateGraphId() to encode user-controlled IDs in Graph API URLs. However, channelId is used unvalidated in the Teams deep-link URL:
url: \https://teams.microsoft.com/l/channel/\\
The Graph API call above it validates and encodes channelId, and getNotificationUrl correctly uses encodeURIComponent for chat IDs — the channel deep-link should do the same for consistency.
What to do
Apply encodeURIComponent to channelId in the deep-link URL in postUpdate().
Origin
Flagged by RETRO (security review) during PR #768 review — Round 2, Note B.
Activity
github-actions commentedon Apr 3, 2026
🏗️ Squad Triage — Flight (Lead)
Issue: #771 — fix(sdk): Encode channelId in Teams deep-link URL
Assigned to: FIDO (Quality Owner)
Reason: Issue relates to testing/quality work
@copilot evaluation: 🔴 Not suitable — issue involves work outside the coding agent's capability profile.
Team roster:
squad:flightsquad:proceduressquad:eecomsquad:fidosquad:paosquad:capcomsquad:controlsquad:surgeonsquad:boostersquad:gncsquad:networksquad:retrosquad:incosquad:guidosquad:telemetrysquad:voxsquad:dskysquad:simssquad:handbooksquad:ralphsquad:copilotfix(sdk): Teams adapter — encode channelId, icacls warning, integrati…
fix(sdk): Teams adapter — encode channelId, icacls warning, integrati…
diberry commentedon Apr 6, 2026
Category: In progress — PR #883 covers this. No PRD needed.
Tracked alongside #772 and #770. All three are Teams adapter follow-ups from PR #768 review.
Action: No action needed — tracking via PR #883.
fix(sdk): Teams adapter — encode channelId, icacls warning, integrati…