Repository navigation
fix(sdk): Log warning when icacls fails on Windows token permission hardening #770
Description
Context
PR #768 added icacls to restrict Teams token file permissions on Windows. However, the exec() callback is a no-op — if icacls fails (unusual path characters, permission denied), the failure is silently swallowed and the token file remains with default Windows ACLs.
What to do
In packages/squad-sdk/src/platform/comms-teams.ts, change the saveTokens() icacls call to log a warning on error:
exec(icacls ..., (err) => {
if (err) console.warn('⚠️ Could not restrict token file permissions:', err.message);
});Origin
Flagged by RETRO (security review) during PR #768 review — Round 1, MEDIUM-1 follow-up note.
Severity: LOW
Related PR: #768
Activity
github-actions commentedon Apr 3, 2026
🏗️ Squad Triage — Flight (Lead)
Issue: #770 — fix(sdk): Log warning when icacls fails on Windows token permission hardening
Assigned to: FIDO (Quality Owner)
Reason: Issue relates to testing/quality work
@copilot evaluation: 🔴 Not suitable — issue involves work outside the coding agent's capability profile.
Team roster:
squad:flightsquad:proceduressquad:eecomsquad:fidosquad:paosquad:capcomsquad:controlsquad:surgeonsquad:boostersquad:gncsquad:networksquad:retrosquad:incosquad:guidosquad:telemetrysquad:voxsquad:dskysquad:simssquad:handbooksquad:ralphsquad:copilotfix(sdk): Teams adapter — encode channelId, icacls warning, integrati…
fix(sdk): Teams adapter — encode channelId, icacls warning, integrati…
diberry commentedon Apr 6, 2026
Category: In progress — PR #883 covers this. No PRD needed.
Tracked alongside #772 and #771. All three are Teams adapter follow-ups from PR #768 review.
Action: No action needed — tracking via PR #883.
fix(sdk): Teams adapter — encode channelId, icacls warning, integrati…