Skip to content

Re-run the live e2e to prove the epic-continuation hop #1767

Closed

Description

@bradygaster

This is the last unproven hop of the epic-continuation chain. Every known blocker in front of it is now merged.

What to run

Fixture repo: bradygaster/aspiregregator-squad-e2e

Comment /squad implement on epic #5. Children #8 (UI affordances) and #9 (test coverage) are still open and blocked.

Success criteria

The worker dispatches #8 as the next wave.

Failure signals to watch for:

  • A new issue titled "Squad workflow dispatch missing command" — means the payload is still being lost
  • A noop with no visible next step — means the continuation path went silent
  • Total silence — no comment and no noop. This exact failure occurred in an earlier run and its root cause was never definitively established. If it recurs, capture the full run log before retrying; that's the highest-value diagnostic available.

Fixes this validates

PR What it fixed
#1741 dispatch inputs interpolated as ${{ github.event.inputs.* }}
#1742 invalid frontmatter YAML (unquoted : in a skill description)
#1744 worker allowed-files widened 64 → 109 globs; package-registry egress
#1747 worker file globs
#1752 correct dispatch payload + fail-loud safety net
#1765 / #1766 schema probe no longer swallows the real payload

Where to look when it runs

  • agent/safeoutputs.jsonl — what the agent actually produced
  • safe-outputs-items/safe-output-items.jsonl — what survived collection

A mismatch between these two is the signature of the probe bug. If they now match, #1766 worked.

Depends on

Nothing — all prerequisite fixes are merged to dev. The consumer workflow must be on a dev that includes #1766.

Related

Fixture-repo hygiene is tracked separately — the older aspiregregator-squad-test repo has hand-created issues that were never produced by a real decomposition.

Activity

  1. bradygaster commented on Aug 20, 2026

    @bradygaster
    CollaboratorAuthor

    Flight sequencing note — gh-aw findings chain.

    Depends on: nothing in this issue chain. Its own target is bradygaster/aspiregregator-squad-e2e, epic #5, with real children #8/#9; it is independent of the older aspiregregator-squad-test fixture decision in #1768. It does need the consumer workflow refreshed to a dev install that includes #1766.

    Blocks:

    Suggested position: Wave 1 of 3. This is the highest-information action available and should run as soon as the fixture workflow refresh is in place.

    Conflict risk: no expected repo-file conflict in bradygaster/squad; risk is external fixture state and run-log capture. Capture agent/safeoutputs.jsonl and safe-outputs-items/safe-output-items.jsonl on failure before retrying.

  2. bradygaster commented on Aug 20, 2026

    @bradygaster
    CollaboratorAuthor

    Outcome correction — the hop was NOT proven

    This was closed at 08:18, before the run it describes started (08:19). Recording the actual result so this issue does not read as a success.

    What the e2e proved: the implement-dispatch hop is clean. /squad implement on epic #5 in bradygaster/aspiregregator-squad-e2e produced exactly one dispatch_workflow call with the payload intact and no schema probe preceding it. Run 32348204357 dispatched worker 32348617589, which opened draft PR #13 for child #8.

    What it did not prove: the merge-continuation hop — the one that stalled the original epic. That only fires when a child PR merges, which had not happened yet at close time.

    Result after merging PR #13 (2026-08-20T16:56Z): the continuation hop fires but its payload is destroyed.

    Worker run 32394811753 succeeded and posted the correct visible next-step comment, so finding B's fix works. But its agent/safeoutputs.jsonl contains two entries:

    {"type":"dispatch_workflow"}
    {"type":"dispatch_workflow","inputs":{"command":"implement","issue_number":"5"},"workflow_name":"squad"}

    max: 1 keeps the first, so the empty probe won. The dispatched Squad run 32395290857 reported success while doing nothing, because it received no command input. Epic #5 got no comment and child #9 was never picked up.

    The fixture was confirmed not stale — its installed worker contains both probe or discover and the FIRST … wins language from #1766. The prompt-level guard did not hold.

    Successor: #1772 carries the defect and the acceptance criteria. This issue stays closed because the re-run itself was performed; the finding lives there.

    Side effect: this also explains the silent-no-op behaviour that had been unexplained across several sessions — a run that dispatches nothing still reports green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or improvement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions