Skip to content

Decide whether to drop bots: from squad.md (compiler concurrency warning) #1763

Closed

Description

@bradygaster

The warning

workflows/squad.md (~L8–14) co-configures both slash_command and bots:. The gh-aw compiler emits a warning on every gh aw add:

a bot listed in bots: posting a comment starting with the slash command text will trigger the workflow and occupy the concurrency slot, potentially blocking manual invocations

Reproduced again during the 2026-08-19 workflow refresh. Pre-existing — not introduced by #1741, #1742, #1744, #1747, or #1752.

Why it's not a trivial delete

The compiler's own recommendation is to remove bots:. But before doing that, verify nothing depends on bot-authored comments triggering Squad.

Specifically: the merge-continuation path posts as github-actions[bot]. If that path relies on a bot comment to trigger the router, removing bots: breaks epic continuation — the exact chain that took three PRs (#1741, #1747, #1752) to get working.

Check this before changing anything.

The decision

  • (a) Remove bots: — follows the compiler's recommendation, only if the continuation path is confirmed not to depend on it
  • (b) Keep it and document the warning as a known, accepted trade-off

Small and isolated. Needs a decision more than it needs code.

⚠️ If you do edit squad.md

Never put a ## heading inside a ## skill: block. The block closes implicitly at the next H2, and everything up to the next skill marker is silently discarded — ~29 KB was lost this way once and it still compiled clean. Skills use #####.

Run npx vitest run test/gh-aw-quality.test.ts before pushing; it asserts zero discarded bytes.

Origin

Finding D from the 2026-08-19 live end-to-end run.

Activity

  1. bradygaster commented on Aug 20, 2026

    @bradygaster
    CollaboratorAuthor

    Flight sequencing note — revised 2026-08-20.

    Wave: 5.

    Depends on:

    Blocks: nothing else in this stream.

    Safe to run in parallel with: mechanically, #1770, #1760, #1761, #1762, #1768, #1756, and #1759 touch disjoint areas. Architecturally, defer this decision until #1772 is fixed and a continuation run is green.

    Why / evidence: workflows/squad.md still has bots: ["github-actions[bot]"] beside slash_command at lines 7-15; workflows/squad-implement-worker.md also has bots: at lines 6-19. Tests assert both at test/gh-aw-implement-workflow.test.ts lines 102-115. #1767's latest outcome showed the implement-dispatch hop is clean but the merge-continuation hop fails; that strengthens the case for deferring #1763. It does not prove bots: caused the failure — #1772's evidence points to dispatch-workflow max: 1 at worker lines 202-205 and a schema probe despite prompt guard lines 226-233.

  2. added
    gh-awGitHub Agentic Workflows integration
    type:spikeResearch/investigation — produces a plan, not code
    triagedIssue has been triaged
    wave:2-soonWave 2 — next 2-4 weeks
    and removed
    questionCommunity question
    on Aug 20, 2026
  3. added
    squadSquad triage inbox — Lead will assign to a member
    on Aug 20, 2026
  4. bradygaster commented on Aug 20, 2026

    @bradygaster
    CollaboratorAuthor

    Closing — keep \�ots:. Removing it breaks a tested expectation with zero functional benefit.

    Booster's triage confirmed:

    1. \�ots: [\github-actions[bot]]\ sits at \workflows/squad.md:8\ and \workflows/squad-implement-worker.md:7.
    2. Merge-continuation fires on \pull_request: types: [closed]\ — it does not depend on bot-authored slash-command comments.
    3. \ est/gh-aw-implement-workflow.test.ts:102-115\ asserts \�ots:\ is present. Removing it would fail that test.
    4. The compiler warning is emitted at compile time, not runtime. Zero E2E impact.
    5. The concurrency hazard is narrow: no current workflow posts a bot comment beginning with /squad. The scenario that would trigger it — a \github-actions[bot]\ comment starting with /squad\ — does not occur in practice.

    This is distinct from #1730's concurrency axis, which addresses issue-scoped concurrency and actor authorization — that remains open (deferred to wave:3). The \�ots:\ compiler warning can be revisited in wave:5 if the team identifies a scenario where it bites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    gh-awGitHub Agentic Workflows integrationpriority:p2Next sprintsquadSquad triage inbox — Lead will assign to a membertriagedIssue has been triagedtype:spikeResearch/investigation — produces a plan, not codewave:2-soonWave 2 — next 2-4 weeks

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions